Skip to content

VeloC plugin#661

Draft
iole-bolognesi wants to merge 27 commits intopdidev:mainfrom
iole-bolognesi:cp-plugin
Draft

VeloC plugin#661
iole-bolognesi wants to merge 27 commits intopdidev:mainfrom
iole-bolognesi:cp-plugin

Conversation

@iole-bolognesi
Copy link
Copy Markdown

@iole-bolognesi iole-bolognesi commented Apr 2, 2026

List of things to check before making a PR

Before merging your code, please check the following:

  • you have added a line describing your changes to the Changelog;
  • you have added unit tests for any new or improved feature;
  • in case you updated dependencies, you have checked pdi/docs/CheckList.md;
  • in case of a change in pdi.h, this same change must be reflected in no-pdi/include/pdi.h;
  • you have checked your code format:
    • you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • you have checked that the indentation and formatting conforms to the .clang-format;
    • you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • your institution is in the copyright header of every file you (substantially) modified;
    • you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • you have added yourself to the AUTHORS file;
    • if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • any new CMake configuration option;
    • any change in the yaml config;
    • any change to the public or plugin API;
    • any other new or changed user-facing feature;
    • any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • your MR solves an identified issue;
    • your commit contain the Fix #issue keyword to autoclose the issue when merged.

…rrectly read and in case of non-failure checkpointing is done but entirely using the decl_hdf5 plugin..
…ence and check the definition of a recovery file by storing it as a class data member (and querying its value) rather than using the length of the node.
…nality: If the datasets' paths depend on simulation parameters, the user can define the last dataset paths. If not, the same dataset paths as defined by the "datasets" key are assumed
…per around the VeloC library. Implemented functionalities of writing checkpoints and restoring the latest checkpoint. Added the Cmake file to build PDI with new plugin. Next step: testing for correctness.
… than on data expose because otherwise multiple checkpoints files were being written for the same iteration. Added tests to: 1) check correct writing of checkpoints 2) check correct restoration after a failure. Tests pass with basic requirements. These need to be expanded.
…ons and fixed naming mismatch in veloc_wrapper.cxx
…ype divided by the number of elements in the case of an array datatype. Added additional check to ensure an error is thrown if a checkpoint event is called before all data to be included in checkpoints has been exposed to PDI.
…nd tests to assert that the expected number of checkpoint files has been written. Added cmake changes to compile tests with library but it still does not work.
…has been made to store the configuration of the veloc plugin. The plugin creates an object of the configuration class and calls its getters method to function correctly. Events of types RECOVER and SYNC_STATE have been added ; recovering at the moment is not automatic on expose. The pdi example ran successfully but only tetsing checkpointing so far.
…ts of logging to debug the recover_var bug which is still not working.
… variable names of the VeloC plugins nd changed minor logic: returning 1 rather than version for subsequent check of return value to be valid
…t . Removed the use of "assert" from existing tests.
@iole-bolognesi iole-bolognesi self-assigned this Apr 2, 2026
… expected yaml tree to make it easier for the user, and added a test for manual recovery of a previous checkpoint file
…over to be coherent with "custom_configuration"
…uired for temporary directories where tests are run
@jbigot jbigot force-pushed the main branch 5 times, most recently from c257c27 to ce93f25 Compare April 22, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant