switch to go mods and primarily fix the paired state bug#58
Open
plutack wants to merge 3 commits intopdf:masterfrom
Open
switch to go mods and primarily fix the paired state bug#58plutack wants to merge 3 commits intopdf:masterfrom
plutack wants to merge 3 commits intopdf:masterfrom
Conversation
2ff0f7c to
0b0e146
Compare
1ec6d9f to
fd0dad6
Compare
Author
|
i had initally made neceessary changes to the extension folders but since it breaks the current extension in the stores. I reverted. |
Author
Repository owner
deleted a comment from
zunjack
Jan 14, 2025
|
@plutack is this PR going to be merged in foreseeable future? |
Author
|
you would need to ask the owner of the repo to know this. I think i will try setting up a github action that build the binary for this fix on my branch |
Author
https://github.com/plutack/kdeconnect-chrome-extension/releases/tag/v0.1.7 |
|
@plutack Works great! Many thanks for sharing. |
Random reviews now disabled, why on earth this isn't the default is beyond me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This primarily address the isTrusted api change to pairstate. Go glide also seems to be non functional as I could not get it to run.
The PR also addresses this by switching to go mod to handle dependencies.
Fixes #56