refactor(server): middleware early-returns object instead of setting ctx.body#976
Open
LucciHank wants to merge 1 commit intopastelsky:bundlephobiafrom
Conversation
if (peek) returns {name, version, peekSuccess: false} but never sets ctx.body or calls next(). In Koa the return value is ignored, so the client receives no body (empty response or 404). The code was clearly intended to short-circuit with a response object.
Affected files: exportsSizes.middleware.js
Signed-off-by: Hoangg Anh <131897682+LucciHank@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
if (peek) returns {name, version, peekSuccess: false} but never sets ctx.body or calls next(). In Koa the return value is ignored, so the client receives no body (empty response or 404). The code was clearly intended to short-circuit with a response object.
Changes
server/middlewares/exportsSizes.middleware.js(modified)Type of Change
Testing
Severity:
highContributed by Lê Thành Chỉnh
Code is a tool. Mindset is the real value.
Closes #975