Open
Conversation
9da1ea8 to
5860442
Compare
gfellerph
reviewed
Mar 2, 2025
Comment on lines
+62
to
+64
| | Slot | Description | | ||
| |------|-------------------------------------------------------------------| | ||
| | `default` | Fallback text to render if the component otherwise fails to load. | |
Collaborator
There was a problem hiding this comment.
Would it make sense to expose a slot for content in the filled in portion of the progress bar (e.g. a percentage number)?
Suggested change
| | Slot | Description | | |
| |------|-------------------------------------------------------------------| | |
| | `default` | Fallback text to render if the component otherwise fails to load. | | |
| | Slot | Description | | |
| |------|-------------------------------------------------------------------| | |
| | `default` | Fallback text to render if the component otherwise fails to load. | | |
| | `fill` | Optional content for the filled in portion of the progress bar. | |
Collaborator
|
Just wanted to see what the proposal looks like: https://codepen.io/tuelsch/pen/EaxoaJx?editors=1010 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an initial implementation to go along with this RFC. More thought is needed in terms of Custom Properties for colours etc.