Skip to content

Fix make docs for multi-group API operators#1897

Open
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:fix_make_docs
Open

Fix make docs for multi-group API operators#1897
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:fix_make_docs

Conversation

@stuggi
Copy link
Copy Markdown
Contributor

@stuggi stuggi commented Apr 17, 2026

The build_docs.sh script assumed all operator API types live directly under v1beta1/*_types.go, but nova-operator moved to a multi-group layout with types under nova/v1beta1/. The hardcoded ls glob failed for this structure.

Replace ls with find -path "/v1beta1/_types.go" to discover types in any v1beta1 subdirectory regardless of nesting depth.

The build_docs.sh script assumed all operator API types live directly
under v1beta1/*_types.go, but nova-operator moved to a multi-group
layout with types under nova/v1beta1/. The hardcoded ls glob failed
for this structure.

Replace ls with find -path "*/v1beta1/*_types.go" to discover types
in any v1beta1 subdirectory regardless of nesting depth.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci openshift-ci bot requested review from abays and fultonj April 17, 2026 15:49
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322326 bytes (315KB)
Base branch size 322326 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 17, 2026

currently failing with https://github.com/openstack-k8s-operators/openstack-operator/actions/runs/24573462131/job/71852528687#step:6:1976

++ ls /home/runner/go/pkg/mod/github.com/openstack-k8s-operators/neutron-operator/api@v0.6.1-0.20260415055437-26247a82c50b/v1beta1/neutronapi_types.go
+ for SERVICE in ${SERVICE_PATH[@]}
+ CTLPLANE_PATHS+=($(ls ${SERVICE}))
++ ls '/home/runner/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/api@v0.6.1-0.20260413153813-b59b2a226c10/v1beta1/*_types.go'
ls: cannot access '/home/runner/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/api@v0.6.1-0.20260413153813-b59b2a226c10/v1beta1/*_types.go': No such file or directory
make: *** [Makefile:107: docs] Error 2
Error: Process completed with exit code 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant