Fix make docs for multi-group API operators#1897
Open
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
Fix make docs for multi-group API operators#1897stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
The build_docs.sh script assumed all operator API types live directly under v1beta1/*_types.go, but nova-operator moved to a multi-group layout with types under nova/v1beta1/. The hardcoded ls glob failed for this structure. Replace ls with find -path "*/v1beta1/*_types.go" to discover types in any v1beta1 subdirectory regardless of nesting depth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OpenStackControlPlane CRD Size Report
Threshold reference
|
Contributor
Author
|
currently failing with https://github.com/openstack-k8s-operators/openstack-operator/actions/runs/24573462131/job/71852528687#step:6:1976 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build_docs.sh script assumed all operator API types live directly under v1beta1/*_types.go, but nova-operator moved to a multi-group layout with types under nova/v1beta1/. The hardcoded ls glob failed for this structure.
Replace ls with find -path "/v1beta1/_types.go" to discover types in any v1beta1 subdirectory regardless of nesting depth.