Placement integration v5 by auniyal61 · Pull Request #1101 · openstack-k8s-operators/nova-operator

auniyal61 · 2026-04-15T06:13:33Z

Merge placement-operator/main into nova-operator with git history

Resources created by the placement-operator are named based on the name of the PlacementAPI CR

Make sure that DeploymentReady condition is set back to False if the Deployment ReadyReplicas falls back to 0

Public/Internal service cert secrets and the CA bundle secret can be passed to configure httpd virtual hosts for tls termination. The certs are mounted to in var/lib/config-data/tls/certs/%s.crt|key and a CA bundle to /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem. Server cert and key are intended to be moved by kolla to /etc/pki/tls/certs|private. Depends-On: openstack-k8s-operators/lib-common#428 Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>

Our intention is to track service operator and lib-common dependencies via pseudoversions. However renovate does not automatically bump from a tagged version (e.g. v0.3.0) to a newer but not tagged pseudoversion. So this patch does the manual bump. After this renovate will bump the newer pseduoversions.

These fields were redundant. Crashing pods can be debugged via oc debug. Implements: OSPRH-4290

Adapt to the new version by: * adding RBAC rules for MariaDBAccount manipulation * adding Own(MariaDBAccount) to detect status changes * separating PlacementAPI CR name from the schema and MariaDBDatabase/Account name * adapting test to simulate MariaDBAccount success * adapting to new DB hostnames due to the mariadb TLS feature

This change modifies how the operator is built to use the ubi9 base image and golang tool chain. A new GO_BUILD_EXTRA_ENV_ARGS build arg is added to the dockerfile to enable the build system to inject addtional parmaters. the default value enable dynmaic linking of glibc which is required for FIPS The prow_ci.env file is extended to enable fips checkign in the prow image build job to validate this change. The Makefile is extened to allow passing build args to docker-build

We only want to support the policy.yaml file passthrough for PlacementAPI The kolla config files are modified to move the supported files in place. Implements: OSPRH-2503

Signed-off-by: Brendan Shephard <bshephar@redhat.com>

This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

This change fixes the Watches declarations to comply with the new controller-runtime standards Signed-off-by: Brendan Shephard <bshephar@redhat.com>

Signed-off-by: Brendan Shephard <bshephar@redhat.com>

…er-runtime Controller runtime update

…rators/revert-144-controller-runtime Revert "Controller runtime update"

This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

Update kustomization.yaml to include placement samples

Update controller-gen paths to process both nova and placement APIs

- Register PlacementAPI controller in cmd/main.go - Register PlacementAPI webhook in cmd/main.go - Add placement scheme and defaults initialization - Fix placement test paths after moving to test/functional/placement/ - Add placement API to test coverage in Makefile

Updated Makefile to include placement webhook paths in controller-gen

Adds getTemplateInstanceType in placement/common.go

Remove placement-import directory - all code has been moved Add generated files from 'make manifests

softwarefactory-project-zuul · 2026-04-15T06:13:41Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/nova-operator for 1101,b54a701efcaf51fb43e59bca78c890dbf09149aa

gibizer · 2026-04-15T07:41:57Z

/hold need testing

gibizer

This is not a real approval just testing if github would allow manually merging this if the approval is persent.

gibizer · 2026-04-15T07:46:24Z

❯ git fetch origin pull/1101/head:pr-1101-merge
X11 forwarding request failed on channel 0
remote: Enumerating objects: 75, done.
remote: Counting objects: 100% (75/75), done.
remote: Compressing objects: 100% (35/35), done.
remote: Total 75 (delta 32), reused 75 (delta 32), pack-reused 0 (from 0)
Unpacking objects: 100% (75/75), 21.19 KiB | 748.00 KiB/s, done.
From github.com:openstack-k8s-operators/nova-operator
 * [new ref]           refs/pull/1101/head -> pr-1101-merge
❯ git merge pr-1101-merge
Updating b59b2a22..b54a701e
Fast-forward

The merge of this is clean now.

gibizer · 2026-04-15T07:50:14Z

OK. Github now agrees that it is mergable.

So what remains:

do testing of the PR both greenfield and update testing
review the commits in the PR that are new. Ignore the commits that are just the same from placement-operator review
line up an openstack-operator patch that rewires the imports and removes the deployment of controllers from placement-operator repo.

Then based on the code review and the manual tests we will override the CI here as zuul is insisting on trying a rebase before testing.

it was not a real approval just a github test

openshift-ci · 2026-04-15T07:52:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: auniyal61

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [auniyal61]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gibizer · 2026-04-15T07:52:37Z

recheck

softwarefactory-project-zuul · 2026-04-15T07:52:48Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/nova-operator for 1101,b54a701efcaf51fb43e59bca78c890dbf09149aa

auniyal61 · 2026-04-15T07:53:56Z

OK. Github now agrees that it is mergable.

So what remains:

do testing of the PR both greenfield and update testing

you mean manual build test ?
functional tests are running

will run kuttl locally
will do day-2 operation after build

review the commits in the PR that are new. Ignore the commits that are just the same from placement-operator review

line up an openstack-operator patch that rewires the imports and removes the deployment of controllers from placement-operator repo.

yep, inprogress.

Then based on the code review and the manual tests we will override the CI here as zuul is insisting on trying a rebase before testing.

still showing, so will we eventually merge manually ?

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
  Error merging github.com/openstack-k8s-operators/nova-operator for 1101,b54a701efcaf51fb43e59bca78c890dbf09149aa

gibizer · 2026-04-15T08:01:31Z

OK. Github now agrees that it is mergable.
So what remains:

do testing of the PR both greenfield and update testing

you mean manual build test ? functional tests are running

will run kuttl locally

will do day-2 operation after build

Yepp.

run kuttl localy post the result
build the nova-operator and an openstack-operator using this PR and the openstack-operator adaptation PR, do a greenfiled deployment with it locally (e.g. with install_yamls) do some spot checks that VMs can be booted etc. Check that placement-operator is not deployed, check that placement controller is running from nova-operator
do a deployment with the official nova- and placement- and openstack-operator. Do an update that brings in a new openstack-operator with the adaptation patch. Check that placement-operator is removed by the update, check the placement controllers are running from nova-operator. Do spot checks that VMs are manageable.

review the commits in the PR that are new. Ignore the commits that are just the same from placement-operator review

I will spend time on this part.

line up an openstack-operator patch that rewires the imports and removes the deployment of controllers from placement-operator repo.

yep, inprogress.

Then based on the code review and the manual tests we will override the CI here as zuul is insisting on trying a rebase before testing.

still showing, so will we eventually merge manually ?
Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
  Error merging github.com/openstack-k8s-operators/nova-operator for 1101,b54a701efcaf51fb43e59bca78c890dbf09149aa

Yes, based on the manual test results and code review I will approve this PR and then I will press the button in Github to merge it against the CI results. Then we will post a DNM PR to trigger CI on the new main.

Replace placement-operator dependency with nova-operator's placement API now that placement code has been integrated into nova-operator - Update all imports from placement-operator/api to nova-operator/api/placement - Remove placement-operator from go.mod and api/go.mod dependencies - Update nova-operator dependency to placement-integration-v5 - Add replace directives pointing to auniyal61/nova-operator fork (temporary) - Clean up go.sum files to remove stale placement-operator entries Depends-On: openstack-k8s-operators/nova-operator#1101

mrkisaolamb and others added 30 commits January 11, 2024 18:24

Use instance.Name in creating resources

f2c967e

Resources created by the placement-operator are named based on the name of the PlacementAPI CR

Set DeploymentReady to False when ReadyCount will be 0

70a7441

Make sure that DeploymentReady condition is set back to False if the Deployment ReadyReplicas falls back to 0

Update openstack-k8s-operators

cfb0ec0

Watch input secret and update deployment if a relevant password changes

443b311

Ensure that DBPasswordSelector is in secret

9c345b1

Update openstack-k8s-operators

dd38d7d

Drop Debug fields

1cf54bf

These fields were redundant. Crashing pods can be debugged via oc debug. Implements: OSPRH-4290

Reorganize main reconcile flow

9b464d5

Remove initcontainer and add more logs

0a36edd

Sync refactor with tls enable patches

2b6962c

Fix scripts volum issue

6c757a9

Change secret mounting path to allign with nova-operator

b437bcf

Update openstack-k8s-operators

24bbd7f

Add missing logic for DefaultConfigOverwrite

9ee07d1

We only want to support the policy.yaml file passthrough for PlacementAPI The kolla config files are modified to move the supported files in place. Implements: OSPRH-2503

Update openstack-k8s-operators

20c6e5f

Update controller-runtime version

8e9d664

Signed-off-by: Brendan Shephard <bshephar@redhat.com>

[webhook] Update webhook functions for CR update

bec9fcc

This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

[manager] Update manager initialisation for CR update

37af0f4

This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

[watches] Fix watches declarations for CR update

e192235

This change fixes the Watches declarations to comply with the new controller-runtime standards Signed-off-by: Brendan Shephard <bshephar@redhat.com>

Update to Go 1.21

eb69b51

Signed-off-by: Brendan Shephard <bshephar@redhat.com>

Merge pull request openstack-k8s-operators#144 from bshephar/controll…

db35921

…er-runtime Controller runtime update

Revert "Controller runtime update"

40e7bce

Merge pull request openstack-k8s-operators#150 from openstack-k8s-ope…

5114005

…rators/revert-144-controller-runtime Revert "Controller runtime update"

Update controller-runtime version

4224ade

[webhook] Update webhook functions for CR update

a2134b9

This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

[manager] Update manager initialisation for CR update

63d4841

This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

auniyal61 added 8 commits April 15, 2026 11:27

Move placement sample files from placement-operator

a2ce013

Update kustomization.yaml to include placement samples

Update Makefile to generate placement manifests

5811ec9

Update controller-gen paths to process both nova and placement APIs

Fix codespell typos in placement code

0d381e3

placement webhook manifests in config/webhook

8d3cd20

Updated Makefile to include placement webhook paths in controller-gen

Updates placement template paths for multi-group structure

387b61d

Adds getTemplateInstanceType in placement/common.go

Cleanup placement-import and add generated manifests

d557d42

Remove placement-import directory - all code has been moved Add generated files from 'make manifests

Keep only the base sample in kustomization

b54a701

openshift-ci bot requested review from SeanMooney and gibizer April 15, 2026 06:13

openshift-ci bot added the approved label Apr 15, 2026

auniyal61 mentioned this pull request Apr 15, 2026

Placement integration v3 #1095

Open

openshift-ci bot added the do-not-merge/hold label Apr 15, 2026

gibizer previously approved these changes Apr 15, 2026

View reviewed changes

openshift-ci bot assigned gibizer Apr 15, 2026

openshift-ci bot added the lgtm label Apr 15, 2026

gibizer self-requested a review April 15, 2026 07:51

auniyal61 mentioned this pull request Apr 15, 2026

Update openstack-operator to use placement API from nova-operator openstack-k8s-operators/openstack-operator#1893

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Placement integration v5#1101

Placement integration v5#1101
auniyal61 wants to merge 667 commits intoopenstack-k8s-operators:mainfrom
auniyal61:placement-integration-v5

auniyal61 commented Apr 15, 2026

Uh oh!

softwarefactory-project-zuul bot commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

gibizer left a comment

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

openshift-ci bot commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

softwarefactory-project-zuul bot commented Apr 15, 2026

Uh oh!

auniyal61 commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Conversation

auniyal61 commented Apr 15, 2026

Uh oh!

softwarefactory-project-zuul bot commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

gibizer left a comment

Choose a reason for hiding this comment

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

openshift-ci bot commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

softwarefactory-project-zuul bot commented Apr 15, 2026

Uh oh!

auniyal61 commented Apr 15, 2026

Uh oh!

gibizer commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants