Skip to content

New Map: Jamaica 🇯🇲#3570

Open
ewxve wants to merge 6 commits intoopenfrontio:mainfrom
ewxve:main
Open

New Map: Jamaica 🇯🇲#3570
ewxve wants to merge 6 commits intoopenfrontio:mainfrom
ewxve:main

Conversation

@ewxve
Copy link
Copy Markdown

@ewxve ewxve commented Apr 3, 2026

Description:

Added Jamaica as a playable map (with weight 4)

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

@neikirk

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ecce069-5d6f-477d-9e7e-be1be81dfd6c

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4b3b6 and b04526c.

📒 Files selected for processing (1)
  • resources/lang/en.json
✅ Files skipped from review due to trivial changes (1)
  • resources/lang/en.json

Walkthrough

Added Jamaica as a new map: assets and manifest files, map-generator registry entry, game enum/category update, playlist frequency, and an English translation key.

Changes

Cohort / File(s) Summary
Map Assets & Manifest
map-generator/assets/maps/jamaica/info.json, resources/maps/jamaica/manifest.json
Added Jamaica map metadata: root name, nations array with coordinates, name, flag, and multi-resolution manifest dimensions and tile counts.
Map Generator Registry
map-generator/main.go
Registered jamaica in the generator's maps list.
Game Types & Categories
src/core/game/Game.ts
Added GameMapType.Jamaica and included it in mapCategories.regional.
Playlist Weighting
src/server/MapPlaylist.ts
Added Jamaica: 6 to the map frequency table used by buildMapsList.
Localization
resources/lang/en.json
Added "jamaica": "Jamaica" to English translations.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as CLI/Developer
    participant Generator as Map Generator
    participant Assets as Map Assets
    participant Server as Game Server
    participant Client as Game Client

    CLI->>Generator: run generate/all (includes "jamaica")
    Generator->>Assets: load `.../jamaica/info.json` and `.../manifest.json`
    Assets-->>Generator: return map metadata and tile config
    Generator->>Server: register generated map artifacts
    CLI->>Server: start server / build playlists
    Server->>Server: buildMapsList (reads frequency with Jamaica:6)
    Server-->>Client: include Jamaica in playlists served to clients
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🗺️ Jamaica joins the map’s bright view,
Flags and points in tidy queue,
Generator hums, the server scores,
Playlists bloom with island shores,
Ready now — the game says “view!”

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates that Jamaica is being added as a new playable map, which directly matches the primary objective of this changeset.
Description check ✅ Passed The description clearly relates to the changeset by stating Jamaica is added as a playable map and includes a checklist confirming proper implementation practices were followed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ewxve ewxve marked this pull request as draft April 3, 2026 07:29
@ewxve ewxve closed this Apr 3, 2026
@github-project-automation github-project-automation bot moved this from Triage to Complete in OpenFront Release Management Apr 3, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@map-generator/assets/maps/jamaica/info.json`:
- Line 2: Update the map metadata "name" field in the Jamaica map info JSON:
change the value currently set as "Europe" to "Jamaica" in the info.json's
"name" property so the map metadata correctly reflects the Jamaica asset and
prevents incorrect naming during asset regeneration.

In `@resources/maps/jamaica/manifest.json`:
- Line 17: The manifest's "name" property is incorrect (currently "Europe");
update the "name" field in resources/maps/jamaica/manifest.json to "Jamaica" so
consumers reading manifest.name receive the correct map name; locate the JSON
object containing the "name" key and replace its value accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d104567a-b2a8-46a6-806d-c507489b7205

📥 Commits

Reviewing files that changed from the base of the PR and between 21c2861 and 8d8b980.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/jamaica/image.png is excluded by !**/*.png
  • resources/maps/jamaica/map.bin is excluded by !**/*.bin
  • resources/maps/jamaica/map16x.bin is excluded by !**/*.bin
  • resources/maps/jamaica/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (7)
  • map-generator/assets/maps/jamaica/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/jamaica/manifest.json
  • resources/maps/jamaica/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Comment thread map-generator/assets/maps/jamaica/info.json Outdated
Comment thread resources/maps/jamaica/manifest.json Outdated
@github-project-automation github-project-automation bot moved this from Complete to Development in OpenFront Release Management Apr 3, 2026
@ewxve ewxve reopened this Apr 3, 2026
@github-project-automation github-project-automation bot moved this from Development to Triage in OpenFront Release Management Apr 3, 2026
ewxve and others added 2 commits April 3, 2026 01:38
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 3, 2026
@github-project-automation github-project-automation bot moved this from Triage to Final Review in OpenFront Release Management Apr 3, 2026
@ewxve ewxve marked this pull request as ready for review April 3, 2026 07:55
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Final Review

Development

Successfully merging this pull request may close these issues.

2 participants