Skip to content

Adds Antarctica map#3560

Closed
RickD004 wants to merge 7 commits intoopenfrontio:mainfrom
RickD004:antarctica
Closed

Adds Antarctica map#3560
RickD004 wants to merge 7 commits intoopenfrontio:mainfrom
RickD004:antarctica

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

@RickD004 RickD004 commented Apr 2, 2026

Description:

Re-adds and reworks the previously April Fools "Reglaciated Antarctica" as a new map, this time with proper elevation data: Map of Antarctica centered in the South Pole.

The "appeal" of this a map is that it has no green terrain. (As such it has a really low rotation number (of 1). )

This also completes the Continental map category (antarctica was the only continent out of the traditional 7 missing).

antarctica.mp4

The base map image is a composite of 2 relief maps from 2 different sources, both properly credited

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 2, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Adds Antarctica as a new game map: assets and manifest, map-generator registration, English label, game enum/category update, playlist weight, and new credit entries for Polar Geospatial Center and USGS dataset.

Changes

Cohort / File(s) Summary
Core Game Type
src/core/game/Game.ts
Added Antarctica to GameMapType and included it in the continental category.
Map generation registry & assets
map-generator/main.go, map-generator/assets/maps/antarctica/info.json
Registered antarctica in the map registry and added info.json with 10 nation entries (coordinates, names, flags).
Map resources / manifest
resources/maps/antarctica/manifest.json
New manifest name: "antarctica" with base/variant dimensions, land-tile counts, and 10 nation definitions.
Localization & playlist
resources/lang/en.json, src/server/MapPlaylist.ts
Added map.antarctica translation entry and set playlist frequency weight Antarctica: 2.
Credits / Attribution
CREDITS.md
Inserted “### Antarctica Map” credit block with Polar Geospatial Center (DOI/Dataverse/version), PGC Terms of Use link, USGS dataset attribution, and public-domain reference lines.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as Developer/CI
  participant Gen as MapGenerator
  participant Assets as AssetsStore
  participant Server as GameServer
  participant Client as GameClient

  Dev->>Gen: build/generate including `antarctica`
  Gen->>Assets: read `assets/maps/antarctica/info.json`
  Gen->>Assets: read `resources/maps/antarctica/manifest.json`
  Gen-->>Server: publish generated map assets/manifest
  Server->>Server: register GameMapType.Antarctica
  Server->>Server: include Antarctica in playlist (weight 2)
  Client->>Server: request map list
  Server-->>Client: return map list including Antarctica
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

❄️ A white new map is added to play,
Flags on ice where penguins stray,
Manifests, credits, and names in line,
Antarctica joins the map design. 🧊

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a new Antarctica map to the system.
Description check ✅ Passed The description is well-related to the changeset, explaining the purpose, features, and background of the Antarctica map addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CREDITS.md`:
- Line 72: Replace the agency name text in CREDITS.md where it currently reads
"U.S Geological Survey" (the line containing the link
https://earthexplorer.usgs.gov/metadata/4980/GT30ANTARCPS/) with the correctly
punctuated "U.S. Geological Survey" to ensure consistent naming across the
credits; update only the visible text portion before or inside the markdown link
so the URL remains unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2e0d64cb-77c1-4a09-8262-44bc73aae597

📥 Commits

Reviewing files that changed from the base of the PR and between b88c3a3 and 582b4ee.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/antarctica/image.png is excluded by !**/*.png
  • resources/maps/antarctica/map.bin is excluded by !**/*.bin
  • resources/maps/antarctica/map16x.bin is excluded by !**/*.bin
  • resources/maps/antarctica/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (8)
  • CREDITS.md
  • map-generator/assets/maps/antarctica/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/antarctica/manifest.json
  • resources/maps/antarctica/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Comment thread CREDITS.md Outdated
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Apr 2, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 2, 2026
@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management Apr 2, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 3, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 4, 2026
@RickD004 RickD004 closed this Apr 6, 2026
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Apr 6, 2026
@RickD004 RickD004 reopened this Apr 16, 2026
@RickD004 RickD004 requested a review from a team as a code owner April 16, 2026 05:42
@github-project-automation github-project-automation Bot moved this from Complete to Triage in OpenFront Release Management Apr 16, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 16, 2026
@RickD004 RickD004 closed this Apr 18, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Apr 18, 2026
@RickD004 RickD004 deleted the antarctica branch April 22, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

1 participant