-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add: built-in agent skill for AI coding assistants (agentskills.io) #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyunhee-jo
wants to merge
14
commits into
main
Choose a base branch
from
feature/agent-skill-odl-pdf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
14cf497
Add: built-in agent skill for AI coding assistants (agentskills.io)
hyunhee-jo faf526c
refactor: apply review feedback (round 1)
hyunhee-jo 98c6cc7
refactor: apply PR review feedback (round 2)
hyunhee-jo c9d3d48
fix: use rapidfuzz Indel API instead of Levenshtein for NID scoring
hyunhee-jo a5715a6
fix: check all hybrid deps (docling + fastapi + uvicorn) in detect-en…
hyunhee-jo 26ece8b
fix: improve CI drift check — self-validation trigger + exit code han…
hyunhee-jo 9a28256
refactor(skill): reduce SKILL.md to 595 lines + close documentation gaps
hyunhee-jo b9e2cb3
fix(skill): make quick-eval.py survive cp1252/cp949 consoles and clea…
hyunhee-jo 1fa360e
test+ci(skill): multi-model evaluation infrastructure and cross-platf…
hyunhee-jo a0c7914
feat(skill): respond to PR review #4251171155 — convention-aligned ta…
hyunhee-jo c1fa607
Merge branch 'main' into feature/agent-skill-odl-pdf
hyunhee-jo e8df66b
refactor(skill): drop API-based eval runner and workflow from PR scope
hyunhee-jo 4db0902
docs(skill): link Version Compatibility table to canonical manifests
hyunhee-jo a23f865
docs(skill): pre-merge polish
hyunhee-jo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "name": "opendataloader-pdf", | ||
| "owner": { | ||
| "name": "OpenDataLoader Project" | ||
| }, | ||
| "metadata": { | ||
| "description": "AI-powered PDF extraction guidance and automation", | ||
| "version": "0.1.0" | ||
| }, | ||
| "plugins": [ | ||
| { | ||
| "name": "odl-pdf-skills", | ||
| "version": "0.1.0", | ||
| "description": "Expert guidance for opendataloader-pdf — environment detection, option recommendations, hybrid mode setup, quality diagnostics, and direct conversion execution", | ||
| "homepage": "https://github.com/opendataloader-project/opendataloader-pdf/tree/main/skills/odl-pdf", | ||
| "source": "./", | ||
| "skills": [ | ||
| "./skills/odl-pdf" | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # skill-drift-check.yml | ||
| # Ensures skill references stay in sync with options.json when CLI options change. | ||
| # Runs sync-skill-refs.py and fails the check if drift is detected (exit code 1). | ||
|
|
||
| name: Skill Drift Check | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - 'options.json' | ||
| - 'skills/odl-pdf/scripts/sync-skill-refs.py' | ||
| pull_request: | ||
| paths: | ||
| - 'options.json' | ||
| - 'skills/odl-pdf/scripts/sync-skill-refs.py' | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| check-drift: | ||
| runs-on: ubuntu-latest | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
|
|
||
| - name: Check skill drift | ||
| run: | | ||
| set +e | ||
| python skills/odl-pdf/scripts/sync-skill-refs.py | ||
| EXIT_CODE=$? | ||
| if [ $EXIT_CODE -eq 1 ]; then | ||
| echo "" | ||
| echo "Drift detected: skill references are out of sync with options.json." | ||
| echo "Update skills/odl-pdf/references/options-matrix.md to match options.json." | ||
| exit 1 | ||
|
coderabbitai[bot] marked this conversation as resolved.
coderabbitai[bot] marked this conversation as resolved.
|
||
| elif [ $EXIT_CODE -ne 0 ]; then | ||
| echo "" | ||
| echo "Drift check failed due to an input/script error (exit $EXIT_CODE)." | ||
| exit $EXIT_CODE | ||
| fi | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| # skill-smoke-test.yml | ||
| # Cross-platform smoke test for the odl-pdf skill's executable assets. | ||
| # Runs the shell scripts and Python scripts on ubuntu / windows / macos | ||
| # to catch platform-specific regressions (line endings, console encoding, | ||
| # shell portability) BEFORE a PR merges. Does NOT hit any external API. | ||
|
|
||
| name: Skill Smoke Test | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - 'skills/odl-pdf/scripts/**' | ||
| - 'skills/odl-pdf/SKILL.md' | ||
| - 'skills/odl-pdf/references/**' | ||
| - '.github/workflows/skill-smoke-test.yml' | ||
| pull_request: | ||
| paths: | ||
| - 'skills/odl-pdf/scripts/**' | ||
| - 'skills/odl-pdf/SKILL.md' | ||
| - 'skills/odl-pdf/references/**' | ||
| - '.github/workflows/skill-smoke-test.yml' | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| smoke-test: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 10 | ||
|
|
||
| defaults: | ||
| run: | ||
| # Use bash on every platform. Windows runners have Git Bash pre-installed. | ||
| shell: bash | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
|
|
||
| - name: Show runner info | ||
| run: | | ||
| echo "OS: ${{ matrix.os }}" | ||
| bash --version | head -1 | ||
| python --version | ||
|
|
||
| # --- detect-env.sh ------------------------------------------------- | ||
| - name: detect-env.sh emits all 7 keys | ||
| run: | | ||
| out=$(bash skills/odl-pdf/scripts/detect-env.sh) | ||
| echo "$out" | ||
| for key in OS JAVA PYTHON NODE ODL_INSTALLED ODL_VERSION HYBRID_EXTRAS; do | ||
| echo "$out" | grep -q "^${key}=" \ | ||
| || { echo "MISSING KEY: $key"; exit 1; } | ||
| done | ||
| echo "all 7 keys present" | ||
|
|
||
| # --- hybrid-health.sh (no server running is expected) -------------- | ||
| - name: hybrid-health.sh handles no-server gracefully | ||
| run: | | ||
| out=$(bash skills/odl-pdf/scripts/hybrid-health.sh) | ||
| echo "$out" | ||
| echo "$out" | grep -q "HYBRID_SERVER=" \ | ||
| || { echo "missing HYBRID_SERVER key"; exit 1; } | ||
|
|
||
| # --- quick-eval.py ------------------------------------------------- | ||
| - name: quick-eval.py --help | ||
| run: python skills/odl-pdf/scripts/quick-eval.py --help | ||
|
|
||
| - name: quick-eval.py identical files -> PASS | ||
| run: | | ||
| tmp=$(mktemp -d) | ||
| printf '# Test\n\nSample paragraph one.\nSample paragraph two.\n' > "$tmp/a.md" | ||
| cp "$tmp/a.md" "$tmp/b.md" | ||
| python skills/odl-pdf/scripts/quick-eval.py "$tmp/a.md" "$tmp/b.md" | ||
| rm -rf "$tmp" | ||
|
|
||
| - name: quick-eval.py different files -> FAIL (exit 1) | ||
| run: | | ||
| tmp=$(mktemp -d) | ||
| printf 'apple pie recipe\n' > "$tmp/a.md" | ||
| printf 'quantum physics lecture\n' > "$tmp/b.md" | ||
| set +e | ||
| python skills/odl-pdf/scripts/quick-eval.py "$tmp/a.md" "$tmp/b.md" | ||
| rc=$? | ||
| set -e | ||
| rm -rf "$tmp" | ||
| [ "$rc" = "1" ] || { echo "expected exit 1, got $rc"; exit 1; } | ||
|
|
||
| - name: quick-eval.py prints em-dash-free output on cp1252 locale (Windows regression) | ||
| if: matrix.os == 'windows-latest' | ||
| shell: cmd | ||
| run: | | ||
| chcp 1252 | ||
| python skills\odl-pdf\scripts\quick-eval.py skills\odl-pdf\evals\evals.json skills\odl-pdf\evals\evals.json | ||
|
|
||
| # --- sync-skill-refs.py -------------------------------------------- | ||
| - name: sync-skill-refs.py reports no drift | ||
| run: python skills/odl-pdf/scripts/sync-skill-refs.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,4 +78,4 @@ content/docs/ | |
| # Configuration files | ||
| .claude/settings.local.json | ||
| .claude/plans/ | ||
|
|
||
| .claude/review-rounds.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.