Skip to content

Fixes #27130: Stored procedure version view shows empty Code tab #27531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyspacex wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Fixes #27130: Stored procedure version view shows empty Code tab #27531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...es/ui/src/components/Database/StoredProcedureVersion/StoredProcedureVersion.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import DataAssetsVersionHeader from '../../DataAssets/DataAssetsVersionHeader/Da
import DataProductsContainer from '../../DataProducts/DataProductsContainer/DataProductsContainer.component';
import EntityVersionTimeLine from '../../Entity/EntityVersionTimeLine/EntityVersionTimeLine';
import TagsContainerV2 from '../../Tag/TagsContainerV2/TagsContainerV2';
import { StoredProcedureCodeCard } from '../StoredProcedureCodeCard/StoredProcedureCodeCard';
import { StoredProcedureVersionProp } from './StoredProcedureVersion.interface';

const StoredProcedureVersion = ({
Expand Down Expand Up @@ -132,6 +133,9 @@ const StoredProcedureVersion = ({
showActions={false}
/>
</Col>
<Col span={24}>
<StoredProcedureCodeCard />
</Col>
</Row>
</Col>
<Col
Expand Down
8 changes: 8 additions & 0 deletions ...sources/ui/src/components/Database/StoredProcedureVersion/StoredProcedureVersion.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ jest.mock('../../common/EntityDescription/DescriptionV1', () =>
jest.fn().mockImplementation(() => <div>DescriptionV1</div>)
);

jest.mock('../StoredProcedureCodeCard/StoredProcedureCodeCard', () => ({
StoredProcedureCodeCard: jest
.fn()
.mockImplementation(() => <div>StoredProcedureCodeCard</div>),
}));

jest.mock('../../Entity/EntityVersionTimeLine/EntityVersionTimeLine', () =>
jest.fn().mockImplementation(() => <div>EntityVersionTimeLine</div>)
);
Expand Down Expand Up @@ -76,6 +82,7 @@ describe('StoredProcedureVersion tests', () => {

const dataAssetsVersionHeader = screen.getByText('DataAssetsVersionHeader');
const description = screen.getByText('DescriptionV1');
const codeCard = screen.getByText('StoredProcedureCodeCard');
const codeTabLabel = screen.getByText('label.code');
const customPropertyTabLabel = screen.getByText(
'label.custom-property-plural'
Expand All @@ -84,6 +91,7 @@ describe('StoredProcedureVersion tests', () => {

expect(dataAssetsVersionHeader).toBeInTheDocument();
expect(description).toBeInTheDocument();
expect(codeCard).toBeInTheDocument();
expect(codeTabLabel).toBeInTheDocument();
expect(customPropertyTabLabel).toBeInTheDocument();
expect(entityVersionTimeLine).toBeInTheDocument();
Expand Down
5 changes: 4 additions & 1 deletion openmetadata-ui/src/main/resources/ui/src/mocks/StoredProcedureVersion.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ const mockData = {
previousVersion: 0.1,
},
deleted: false,
storedProcedureCode: '',
storedProcedureCode: {
code: 'CREATE OR REPLACE PROCEDURE update_dim_address_table()',
language: 'SQL',
},
};

export const storedProcedureVersionMockProps: StoredProcedureVersionProp = {
Expand Down
Loading