Entity Type quick filter labels are formatted on UI side for proper readable casing.#27515
Entity Type quick filter labels are formatted on UI side for proper readable casing.#27515Jenishpadasala30 wants to merge 3 commits intoopen-metadata:mainfrom
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
…omprehensive documentation and test coverage
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ Approved 2 resolved / 2 findingsUpdates the test import path and implements proper bracket notation for array field traversal to fix issue 26805. All identified compilation and logic errors have been resolved. ✅ 2 resolved✅ Bug: Test file has wrong import path — will fail to compile
✅ Bug: Dot-notation traversal fails for array fields (tags, owners)
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Describe your changes:
Fixes #26805
Problem
Explore quick filters were displaying values in lowercase (e.g.,
sample_airflow,john.doe) due to Elasticsearch.keywordfields usinglowercase_normalizer. This caused a poor user experience as original casing from the data source was not preserved.Solution
sourceFields(introduced in Fix : case-insensitive issue with aggregation API response #20734)top_hitssub-aggregation to fetch original values from_sourcesourceFieldsbased on filter keys_sourcevalues instead ofbucket.keysourceFieldsis not providedImplementation
Passed
sourceFieldsthrough ExploreQuickFilters → ExploreUtils → APIUpdated
getOptionsFromAggregationBucketto extract values fromtop_hitsAdded safety checks to handle missing
top_hitsdataCovered special cases like:
service.name→service.displayNametags.tagFQN→tags.displayNametier.tagFQN→tags.displayNameTesting
Verified UI shows proper casing:
sample_airflow→SAMPLE_AIRFLOWjohn.doe→John Doeproduct→Product DomainConfirmed API returns
top_hitsonly whensourceFieldsis passedTested fallback behavior when
sourceFieldsis not providedAdded unit tests for aggregation parsing logic
Result
Explore quick filters now display correctly cased values while maintaining case-insensitive filtering behavior.
Type of change:
Checklist:
Fixes #26805: Preserve casing in Explore quick filters using sourceFields