Skip to content

fix: resolve dashboard card layout broken by long translations in Russian locale #27509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshu748 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −3
Open

fix: resolve dashboard card layout broken by long translations in Russian locale #27509

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e30d5e4
fix: resolve dashboard card layout broken by long translations in Rus…
himanshu748 Apr 18, 2026
f9f7309
fix: make label ellipsis conditional in ExtraInfoLink to address Copi…
himanshu748 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,14 @@ export const ExtraInfoLabel = ({
return (
<div className="d-flex align-start extra-info-container">
<Typography.Text
className="whitespace-nowrap text-sm d-flex flex-col gap-2 w-full"
className="text-sm d-flex flex-col gap-2 w-full"
data-testid={dataTestId}>
{!isEmpty(label) && (
<span className="extra-info-label-heading">{label}</span>
<Typography.Text
className="extra-info-label-heading"
ellipsis={{ tooltip: true }}>
{label}
</Typography.Text>
)}

<Typography.Text
Expand Down Expand Up @@ -140,7 +144,11 @@ export const ExtraInfoLink = ({
'w-48': ellipsis,
})}>
{!isEmpty(label) && (
<span className="extra-info-label-heading m-r-xss">{label}</span>
<Typography.Text
className="extra-info-label-heading m-r-xss"
ellipsis={{ tooltip: true }}>
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExtraInfoLink now applies ellipsis={{ tooltip: true }} to the label unconditionally, even when the ellipsis prop is false. This makes the prop’s behavior inconsistent (it currently only controls adding w-48) and can unexpectedly truncate labels in callers that didn’t opt into ellipsis. Consider applying the label ellipsis conditionally based on the ellipsis prop (or rename/remove the prop if the intent is to always truncate labels).

Suggested change
ellipsis={{ tooltip: true }}>
ellipsis={ellipsis ? { tooltip: true } : false}>

Copilot uses AI. Check for mistakes.
{label}
</Typography.Text>
)}
<div className="d-flex items-center gap-1">
<Tooltip title={value}>
Expand Down
Loading