fix page crash for data products with 0 domains#27230
Merged
shrabantipaul-collate merged 2 commits intomainfrom Apr 10, 2026
Merged
fix page crash for data products with 0 domains#27230shrabantipaul-collate merged 2 commits intomainfrom
shrabantipaul-collate merged 2 commits intomainfrom
Conversation
Code Review ✅ ApprovedFixes page crash when data products have zero domains. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
chirag-madlani
approved these changes
Apr 10, 2026
Contributor
|
Contributor
🟡 Playwright Results — all passed (24 flaky)✅ 3599 passed · ❌ 0 failed · 🟡 24 flaky · ⏭️ 207 skipped
🟡 24 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Contributor
|
Failed to cherry-pick changes to the 1.12.5 branch. |
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
shrabantipaul-collate
added a commit
that referenced
this pull request
Apr 17, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The failure is a frontend crash in the Explore rendering path, triggered by dataProduct search hits that have an empty domains array.

Fix:
Screen.Recording.2026-04-10.at.12.26.07.PM.mov
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>