Skip to content

Fixed pagination tests failures#27121

Closed
Rohit0301 wants to merge 1 commit into1.12.5from
fix-aut-failure-pagination
Closed

Fixed pagination tests failures#27121
Rohit0301 wants to merge 1 commit into1.12.5from
fix-aut-failure-pagination

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

@Rohit0301 Rohit0301 commented Apr 7, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test selector updates:
    • Replaced generic 'table' selectors with specific data-testid attributes ('[data-testid="databaseSchema-tables"]', '[data-testid="service-children-table"]', '[data-testid="stored-procedure-table"]', '[data-testid="database-databaseSchemas"]', '[data-testid="data-models-table"]') across pagination tests
    • Updated six test suites to use more reliable element targeting for pagination navigation validation

This will update automatically on new commits.

@Rohit0301 Rohit0301 requested a review from a team as a code owner April 7, 2026 09:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 7, 2026

Code Review ✅ Approved

Fixes pagination test failures in the 1.12.5 branch. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Apr 7, 2026
@Rohit0301 Rohit0301 self-assigned this Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

❌ Lint Check Failed — ESLint + Prettier (core-components)

The following files have style issues that need to be fixed:

Fix locally (fast — only for changed files in the branch):

make ui-checkstyle-core-components-changed

Or to fix all files:

make ui-checkstyle-core-components

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

❌ Playwright Lint Check Failed — ESLint + Prettier + Organise Imports

The following files have style issues that need to be fixed:
playwright/e2e/Features/Pagination.spec.ts

Fix locally (fast — only for changed files in the branch):

make ui-checkstyle-playwright-changed

Or to fix all playwright files:

make ui-checkstyle-playwright

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.97% (57435/87059) 45.64% (30358/66514) 48.41% (9115/18828)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@Rohit0301 Rohit0301 closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant