Skip to content

fix(test): impact analysis selector fix #27118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohityadav766 merged 6 commits into from
Apr 7, 2026
Merged

fix(test): impact analysis selector fix #27118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
07e8ee7
fix(test): impact analysis selector fix
chirag-madlani Apr 7, 2026
37156e9
fix lineage spec
chirag-madlani Apr 7, 2026
2722cf7
fix tests
chirag-madlani Apr 7, 2026
3922972
fix filter button issue
chirag-madlani Apr 7, 2026
681f719
fix missing piece
chirag-madlani Apr 7, 2026
1a987e3
fix failing spec
chirag-madlani Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ImpactAnalysis.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ test.describe('Impact Analysis', () => {
test('verify owner filter for Asset level impact analysis', async ({
page,
}) => {
await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId('search-dropdown-Owners').click();

await expect(
Expand All @@ -456,7 +456,7 @@ test.describe('Impact Analysis', () => {
});

test('verify domain for Asset level impact analysis', async ({ page }) => {
await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId('search-dropdown-Domains').click();

await expect(
Expand Down Expand Up @@ -485,7 +485,7 @@ test.describe('Impact Analysis', () => {
});

test('verify tier for Asset level impact analysis', async ({ page }) => {
await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId('search-dropdown-Tier').click();

await expect(
Expand Down Expand Up @@ -874,7 +874,7 @@ test.describe('Impact Analysis', () => {
test('Verify service type filter for Asset level impact analysis', async ({
page,
}) => {
await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId('search-dropdown-Service Type').click();

const serviceTypeOption = page.getByTitle('mlflow', { exact: true });
Expand Down Expand Up @@ -917,7 +917,7 @@ test.describe('Impact Analysis', () => {

const initialRowCount = await page.locator('[data-row-key]').count();

await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId('search-dropdown-Tag').click();

await waitForAllLoadersToDisappear(page);
Expand Down Expand Up @@ -978,7 +978,7 @@ test.describe('Impact Analysis', () => {
test('Verify switching between table and column level clears filters', async ({
page,
}) => {
await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId('search-dropdown-Tier').click();

await page
Expand Down Expand Up @@ -1043,7 +1043,7 @@ test.describe('Impact Analysis', () => {
await columnLineageResponse;
await waitForAllLoadersToDisappear(page);

await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId('search-dropdown-Glossary Terms').click();
const glossaryOptions = page
.getByTestId('drop-down-menu')
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ test.describe('Lineage Settings modal', () => {
});

test.beforeEach(async ({ page }) => {
await redirectToHomePage(page);
await table.visitEntityPage(page);
await visitLineageTab(page);
});
Expand Down
6 changes: 4 additions & 2 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
getApiContext,
getDefaultAdminAPIContext,
getEntityTypeSearchIndexMapping,
redirectToHomePage,
} from '../../../utils/common';
import { waitForAllLoadersToDisappear } from '../../../utils/entity';
import {
Expand Down Expand Up @@ -124,6 +125,7 @@ test.describe('Lineage Filters', () => {
});

test.beforeEach(async ({ page }) => {
await redirectToHomePage(page);
await lineageEntity.visitEntityPage(page);
await visitLineageTab(page);
await waitForAllLoadersToDisappear(page);
Expand Down Expand Up @@ -274,7 +276,7 @@ test.describe('Lineage Filters', () => {
await page.reload();
await waitForAllLoadersToDisappear(page);

await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId(`search-dropdown-${filterTestId}`).click();

await page.getByTitle(filterValue).click();
Expand Down Expand Up @@ -316,7 +318,7 @@ test.describe('Lineage Filters', () => {
await impactAnalysisTab.click();
await waitForAllLoadersToDisappear(page);

await page.getByTestId('filters-button').click();
await page.getByRole('button', { name: 'Filters' }).click();
await page.getByTestId(`search-dropdown-${filterTestId}`).click();

await page
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ test.beforeAll(async ({ browser }) => {
});

test.beforeEach(async ({ page }) => {
await redirectToHomePage(page);
await table.visitEntityPage(page);
await visitLineageTab(page);
await performZoomOut(page);
Expand Down
30 changes: 15 additions & 15 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,21 +151,21 @@ const DASHBOARD_DATA_MODEL = 'DashboardDataModel';

export const getEntityTypeSearchIndexMapping = (entityType: string) => {
const entityMapping = {
Table: 'table',
Topic: 'topic',
Dashboard: 'dashboard',
Pipeline: 'pipeline',
MlModel: 'mlmodel',
Container: 'container',
SearchIndex: 'searchIndex',
ApiEndpoint: 'apiEndpoint',
Metric: 'metric',
['Store Procedure']: 'storedProcedure',
Directory: 'directory',
File: 'file',
Spreadsheet: 'spreadsheet',
Worksheet: 'worksheet',
[DASHBOARD_DATA_MODEL]: 'dashboardDataModel',
Table: 'table_search_index',
Topic: 'topic_search_index',
Dashboard: 'dashboard_search_index',
Pipeline: 'pipeline_search_index',
MlModel: 'mlmodel_search_index',
Container: 'container_search_index',
SearchIndex: 'search_entity_search_index',
ApiEndpoint: 'api_endpoint_search_index',
Metric: 'metric_search_index',
['Store Procedure']: 'stored_procedure_search_index',
Directory: 'directory_search_index',
File: 'file_search_index',
Spreadsheet: 'spreadsheet_search_index',
Worksheet: 'worksheet_search_index',
[DASHBOARD_DATA_MODEL]: 'dashboard_data_model_search_index',
};

return entityMapping[entityType as keyof typeof entityMapping];
Expand Down
12 changes: 6 additions & 6 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export const editLineageClick = async (page: Page) => {
export const editLineage = async (page: Page) => {
await editLineageClick(page);

await expect(page.getByTestId('table-draggable-icon')).toBeVisible();
await expect(page.getByTestId('table_search_index-draggable-icon')).toBeVisible();
};

export const performZoomOut = async (page: Page, xTimes = 10) => {
Expand Down Expand Up @@ -642,7 +642,7 @@ export const getEntityColumns = (
};

export const openImpactAnalysisTab = async (page: Page) => {
const impactAnalysisTab = page.getByRole('tab', {
const impactAnalysisTab = page.getByRole('button', {
name: 'Impact Analysis',
});

Expand Down Expand Up @@ -719,9 +719,9 @@ export const verifyCSVHeaders = async (headers: string[]) => {
};

export const getLineageCSVData = async (page: Page) => {
await expect(page.getByTestId('export-button')).toBeEnabled();
await expect(page.getByRole('button', { name: 'Export' })).toBeEnabled();

await page.getByTestId('export-button').click();
await page.getByRole('button', { name: 'Export' }).click();

await page
.locator('[data-testid="export-entity-modal"] #submit-button')
Expand Down Expand Up @@ -804,9 +804,9 @@ export const verifyExportLineagePNG = async (
page: Page,
isPNGSelected?: boolean
) => {
await expect(page.getByTestId('export-button')).toBeEnabled();
await expect(page.getByRole('button', { name: 'Export' })).toBeEnabled();

await page.getByTestId('export-button').click();
await page.getByRole('button', { name: 'Export' }).click();

await page
.locator('[data-testid="export-entity-modal"] #submit-button')
Expand Down
Loading