-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Refactor code splitting and optimize chunk loading in Vite config #26906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
2b01c81
refactor: implement code splitting for pages and optimize manual chun…
chirag-madlani e134644
handle chunk loading error gracefully
chirag-madlani 3c6a6ad
Merge branch 'main' into enahncement-loading-time
chirag-madlani d9f1e8a
address comments
chirag-madlani a889d04
fix lint comment
chirag-madlani 3a6bfd2
address copilot comments
chirag-madlani 515db48
fix chunk and initial load time
chirag-madlani 9b0ee89
fix theme issues
chirag-madlani df8ba10
fix packaging
chirag-madlani bfa39d1
update imports
chirag-madlani cd6ac88
improve imports
chirag-madlani bdbfcaa
Merge branch 'main' into enahncement-loading-time
chirag-madlani fcb911a
run checkstyle
chirag-madlani 6874953
fix build
chirag-madlani f384934
fix css imports
chirag-madlani 0b78f06
update
chirag-madlani 73904cb
Merge branch 'main' into enahncement-loading-time
chirag-madlani 0ec3718
improve imports
chirag-madlani 69c53c5
lazy load local options
chirag-madlani 2a60599
refactor entityUtils
chirag-madlani 2de630f
update
chirag-madlani 1414cec
update
chirag-madlani 203e3e0
fix failures
chirag-madlani 52333ac
apply checkstyle
chirag-madlani a12427a
Merge branch 'main' into enahncement-loading-time
chirag-madlani f35d8e6
fix build issue
chirag-madlani 269a59d
address comments
chirag-madlani af65a6a
fix import error
chirag-madlani 84daf1e
fix import error
chirag-madlani 7fce04e
fix tests
chirag-madlani b089ef6
fix tests
chirag-madlani 9ee338e
move local to classBase approach
chirag-madlani c276740
Merge branch 'main' into enahncement-loading-time
chirag-madlani 8d15f9e
fix tests and update local usage
chirag-madlani 3aab0f5
Merge branch 'main' into enahncement-loading-time
chirag-madlani 61adb1a
fix import error
chirag-madlani 2cd98fb
Merge branch 'main' into enahncement-loading-time
chirag-madlani 1ee853a
fix unit tests
chirag-madlani 368ab82
fix entityUtils imports
chirag-madlani 0b8c957
fix test and checkstyle
chirag-madlani 9a18131
fix failing playwright
chirag-madlani 11b2b24
fix plugin issue
chirag-madlani 7dfc9c1
Merge branch 'main' into enahncement-loading-time
chirag-madlani 1518df3
address comments
chirag-madlani c685ef9
address comments
chirag-madlani 2747ce8
fix unit tests
chirag-madlani 99e2576
Merge branch 'main' into enahncement-loading-time
chirag-madlani b11ef67
address comment
chirag-madlani f05a560
fix localization issue with playwright
chirag-madlani 6a551ff
fix login.spec
chirag-madlani 61d790e
Merge branch 'main' into enahncement-loading-time
chirag-madlani d66719b
fix login spec failure
chirag-madlani 1d4be7f
Merge branch 'main' into enahncement-loading-time
chirag-madlani 92cfc32
fix login spec
chirag-madlani eff7401
address comments
chirag-madlani a6f63a6
Merge branch 'main' into enahncement-loading-time
chirag-madlani 9707eba
final fix to icons
chirag-madlani b697ab8
Merge branch 'main' into enahncement-loading-time
chirag-madlani 15ee0ad
Merge branch 'main' into enahncement-loading-time
chirag-madlani bc47919
fix failing playwrights
chirag-madlani 179c8bd
fix checkstyle
chirag-madlani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says this “Fixes #3457” (replying on deleted entity threads), but the changes here are build/routing performance tweaks (APP_VERSION env var for cache busting) and don’t appear related to that backend/UI behavior. Please update the PR title/description to reference the correct issue, or link the relevant issue for these frontend build optimizations.