-
Notifications
You must be signed in to change notification settings - Fork 1.9k
RDF, cleanup relations and remove unnecessary bindings, add distributed mode for RDF reindex #26902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 56 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
b0fa59c
RDF, cleanup relations and remove unnecessary bindings, add distribut…
harshach 5d9a6a9
Merge branch 'main' into rdf_v2
harshach b0aef60
Update generated TypeScript types
github-actions[bot] 7d46a65
Merge branch 'main' into rdf_v2
harshach 156f039
Address comments from copilot
harshach 4a1e083
Merge remote-tracking branch 'origin/rdf_v2' into rdf_v2
harshach e0f35aa
Update generated TypeScript types
github-actions[bot] 1f22b97
Merge remote-tracking branch 'origin/main' into rdf_v2
aniketkatkar97 e259ec0
fix test issues
harshach fabade4
Merge remote-tracking branch 'origin/rdf_v2' into rdf_v2
harshach ec70141
Merge branch 'main' into rdf_v2
aniketkatkar97 2841a12
Fix minor UI bugs
aniketkatkar97 88672fc
Add the missing filters
aniketkatkar97 8448869
Fix RDF export API error
aniketkatkar97 31b761d
Add export functionality
aniketkatkar97 e29eea2
Fix ui-checkstyle
aniketkatkar97 cfc7769
Merge branch 'main' into rdf_v2
aniketkatkar97 bed18d9
Fix java checkstyle
aniketkatkar97 706a3fc
Fix unit tests
aniketkatkar97 5273179
Fix and increase the coverage for KnowledgeGraph.spec.ts
aniketkatkar97 1062f0c
Merge branch 'main' into rdf_v2
aniketkatkar97 1452a2f
Merge branch 'main' into rdf_v2
aniketkatkar97 fb1efe5
Merge branch 'main' into rdf_v2
aniketkatkar97 6c2a1e1
Merge remote-tracking branch 'origin/main' into rdf_v2
harshach 7dd2925
Fix tests
harshach 30b8d0b
Merge branch 'main' into rdf_v2
harshach 49cca4c
Remove rdf as default in playwright and local docker
harshach 8a5de75
Merge remote-tracking branch 'origin/rdf_v2' into rdf_v2
harshach 0f91604
Merge remote-tracking branch 'origin/main' into rdf_v2
aniketkatkar97 3664b0e
fix ui-checkstyle
aniketkatkar97 0e4df9c
Merge branch 'main' into rdf_v2
aniketkatkar97 33abb30
Address comments
harshach 1f32af1
Merge remote-tracking branch 'origin/rdf_v2' into rdf_v2
harshach dcd2b4c
Merge remote-tracking branch 'origin/main' into rdf_v2
harshach 8ff7aae
Potential fix for pull request finding 'CodeQL / Artifact poisoning'
harshach 82c6a23
Address copilot comments
harshach b73e7f5
Address copilot comments
harshach 8814747
FIx tests
harshach 5b89ec2
Merge branch 'main' into rdf_v2
harshach cfacda1
FIx docker
harshach d84a8d7
Merge remote-tracking branch 'origin/rdf_v2' into rdf_v2
harshach e3f0f5d
Update openmetadata-service/src/main/java/org/openmetadata/service/ap…
harshach 3037499
Address copilot review comments: license headers, JSON escaping, type…
Copilot 835debc
Show error toast for unsupported export format in KnowledgeGraph
Copilot 54c177f
Fix docker
harshach 4d4b807
Merge remote-tracking branch 'origin/rdf_v2' into rdf_v2
harshach 7a34b67
Fix docker for playwright
harshach 22cb1bc
Fix docker for playwright
harshach ae5bf8f
Fix tests
harshach b3c792e
Fix tests
harshach 986101c
Fix docker
harshach c69ac4f
Fix docker
harshach 1a94234
Merge branch 'main' into rdf_v2
aniketkatkar97 2432c3a
Merge branch 'main' into rdf_v2
aniketkatkar97 4bddb71
Fix glossary and pagination spec flakiness
aniketkatkar97 6ab8c15
Merge branch 'main' into rdf_v2
aniketkatkar97 7375993
update the missing translations
aniketkatkar97 aee1f34
Fix docker
harshach c3c4255
Merge remote-tracking branch 'origin/rdf_v2' into rdf_v2
harshach a092978
Fix docker
harshach c855b49
Fix integration test
aniketkatkar97 e984879
Fix fuseki not starting
aniketkatkar97 38d8ccf
Merge branch 'main' into rdf_v2
aniketkatkar97 df8374c
Fixed the run local docker script
aniketkatkar97 fb4406b
worked on comments
aniketkatkar97 8c97479
Merge branch 'main' into rdf_v2
aniketkatkar97 f6123c4
Fix flakiness in knowledge graph tests
aniketkatkar97 2058a5f
Fix checkstyle
aniketkatkar97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| docker/development/docker-volume | ||
| docker/docker-compose-quickstart/docker-volume |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
209 changes: 209 additions & 0 deletions
209
.github/workflows/playwright-knowledge-graph-postgresql-e2e.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,209 @@ | ||
| # Copyright 2021 Collate | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name: Postgresql PR Knowledge Graph E2E Tests | ||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review | ||
| paths: | ||
| - ".github/actions/setup-openmetadata-test-environment/action.yml" | ||
| - ".github/workflows/playwright-knowledge-graph-postgresql-e2e.yml" | ||
| - "docker/run_local_docker.sh" | ||
| - "docker/run_local_docker_common.sh" | ||
| - "docker/run_local_docker_rdf.sh" | ||
| - "docker/validate_compose.py" | ||
| - "docker/development/docker-compose-fuseki.yml" | ||
| - "docker/development/docker-compose-postgres-fuseki.yml" | ||
| - "docs/rdf-local-development.md" | ||
| - "openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/rdf/**" | ||
| - "openmetadata-service/src/main/java/org/openmetadata/service/rdf/**" | ||
| - "openmetadata-service/src/main/java/org/openmetadata/service/resources/rdf/**" | ||
| - "openmetadata-service/src/test/java/org/openmetadata/service/apps/bundles/rdf/**" | ||
| - "openmetadata-service/src/test/java/org/openmetadata/service/rdf/**" | ||
| - "openmetadata-service/src/test/java/org/openmetadata/service/resources/rdf/**" | ||
| - "openmetadata-spec/src/main/resources/rdf/**" | ||
| - "openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/KnowledgeGraph.spec.ts" | ||
| - "openmetadata-ui/src/main/resources/ui/playwright.config.ts" | ||
| - "openmetadata-ui/src/main/resources/ui/src/components/KnowledgeGraph/**" | ||
| - "openmetadata-ui/src/main/resources/ui/src/components/OntologyExplorer/**" | ||
| - "openmetadata-ui/src/main/resources/ui/src/rest/rdfAPI.ts" | ||
| - "openmetadata-ui/src/main/resources/ui/src/types/knowledgeGraph.types.ts" | ||
| - "openmetadata-ui/src/main/resources/ui/src/utils/TableUtils.tsx" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: playwright-knowledge-graph-pr-postgresql-${{ github.event.pull_request.number || github.run_id }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event_name != 'pull_request' || !github.event.pull_request.draft }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} | ||
|
|
||
| - name: Setup JDK 21 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '21' | ||
| distribution: 'temurin' | ||
|
|
||
| - name: Cache Maven Dependencies | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.m2 | ||
| key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-maven- | ||
|
|
||
| - name: Install antlr cli | ||
| run: sudo make install_antlr_cli | ||
|
|
||
| - name: Build with Maven | ||
| run: mvn -DskipTests clean package | ||
|
|
||
| - name: Upload Maven build artifact | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: openmetadata-build | ||
| path: openmetadata-dist/target/openmetadata-*.tar.gz | ||
| retention-days: 1 | ||
|
|
||
| playwright-knowledge-graph-postgresql: | ||
| needs: [build] | ||
| runs-on: ubuntu-latest | ||
| if: ${{ !cancelled() && needs.build.result == 'success' && (github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork) }} | ||
| environment: test | ||
| steps: | ||
| - name: Free Disk Space (Ubuntu) | ||
| uses: jlumbroso/free-disk-space@main | ||
| with: | ||
| tool-cache: false | ||
| android: true | ||
| dotnet: true | ||
| haskell: true | ||
| large-packages: false | ||
| swap-storage: true | ||
| docker-images: false | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} | ||
|
|
||
| - name: Prepare temporary directory for Maven build artifact | ||
| run: mkdir -p "${{ runner.temp }}/openmetadata-build-artifact" | ||
|
|
||
| - name: Download Maven build artifact | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: openmetadata-build | ||
| path: ${{ runner.temp }}/openmetadata-build-artifact | ||
|
|
||
| - name: Copy Maven build artifact into workspace | ||
| run: | | ||
| mkdir -p openmetadata-dist/target | ||
| cp -a "${{ runner.temp }}/openmetadata-build-artifact/." openmetadata-dist/target/ | ||
|
|
||
| - name: Setup Openmetadata Test Environment | ||
| uses: ./.github/actions/setup-openmetadata-test-environment | ||
| with: | ||
| python-version: "3.10" | ||
| args: "-d postgresql -s true" | ||
| startup-script: "./docker/run_local_docker_rdf.sh" | ||
| ingestion_dependency: "all" | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: "openmetadata-ui/src/main/resources/ui/.nvmrc" | ||
|
|
||
| - name: Install dependencies | ||
| working-directory: openmetadata-ui/src/main/resources/ui/ | ||
| run: yarn --ignore-scripts --frozen-lockfile | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
|
|
||
| - name: Install Playwright Browsers | ||
| run: npx playwright@1.57.0 install chromium --with-deps | ||
|
|
||
| - name: Run Knowledge Graph Playwright tests | ||
| working-directory: openmetadata-ui/src/main/resources/ui/ | ||
| run: npx playwright test --project="Knowledge Graph" | ||
| env: | ||
| PLAYWRIGHT_IS_OSS: true | ||
| PLAYWRIGHT_SNOWFLAKE_USERNAME: ${{ secrets.TEST_SNOWFLAKE_USERNAME }} | ||
| PLAYWRIGHT_SNOWFLAKE_PASSWORD: ${{ secrets.TEST_SNOWFLAKE_PASSWORD }} | ||
| PLAYWRIGHT_SNOWFLAKE_ACCOUNT: ${{ secrets.TEST_SNOWFLAKE_ACCOUNT }} | ||
| PLAYWRIGHT_SNOWFLAKE_DATABASE: ${{ secrets.TEST_SNOWFLAKE_DATABASE }} | ||
| PLAYWRIGHT_SNOWFLAKE_WAREHOUSE: ${{ secrets.TEST_SNOWFLAKE_WAREHOUSE }} | ||
| PLAYWRIGHT_SNOWFLAKE_PASSPHRASE: ${{ secrets.TEST_SNOWFLAKE_PASSPHRASE }} | ||
| PLAYWRIGHT_BQ_PRIVATE_KEY: ${{ secrets.TEST_BQ_PRIVATE_KEY }} | ||
| PLAYWRIGHT_BQ_PROJECT_ID: ${{ secrets.PLAYWRIGHT_BQ_PROJECT_ID }} | ||
| PLAYWRIGHT_BQ_PRIVATE_KEY_ID: ${{ secrets.TEST_BQ_PRIVATE_KEY_ID }} | ||
| PLAYWRIGHT_BQ_PROJECT_ID_TAXONOMY: ${{ secrets.TEST_BQ_PROJECT_ID_TAXONOMY }} | ||
| PLAYWRIGHT_BQ_CLIENT_EMAIL: ${{ secrets.TEST_BQ_CLIENT_EMAIL }} | ||
| PLAYWRIGHT_BQ_CLIENT_ID: ${{ secrets.TEST_BQ_CLIENT_ID }} | ||
| PLAYWRIGHT_REDSHIFT_HOST: ${{ secrets.E2E_REDSHIFT_HOST_PORT }} | ||
| PLAYWRIGHT_REDSHIFT_USERNAME: ${{ secrets.E2E_REDSHIFT_USERNAME }} | ||
| PLAYWRIGHT_REDSHIFT_PASSWORD: ${{ secrets.E2E_REDSHIFT_PASSWORD }} | ||
| PLAYWRIGHT_REDSHIFT_DATABASE: ${{ secrets.TEST_REDSHIFT_DATABASE }} | ||
| PLAYWRIGHT_METABASE_USERNAME: ${{ secrets.TEST_METABASE_USERNAME }} | ||
| PLAYWRIGHT_METABASE_PASSWORD: ${{ secrets.TEST_METABASE_PASSWORD }} | ||
| PLAYWRIGHT_METABASE_DB_SERVICE_NAME: ${{ secrets.TEST_METABASE_DB_SERVICE_NAME }} | ||
| PLAYWRIGHT_METABASE_HOST_PORT: ${{ secrets.TEST_METABASE_HOST_PORT }} | ||
| PLAYWRIGHT_SUPERSET_USERNAME: ${{ secrets.TEST_SUPERSET_USERNAME }} | ||
| PLAYWRIGHT_SUPERSET_PASSWORD: ${{ secrets.TEST_SUPERSET_PASSWORD }} | ||
| PLAYWRIGHT_SUPERSET_HOST_PORT: ${{ secrets.TEST_SUPERSET_HOST_PORT }} | ||
| PLAYWRIGHT_KAFKA_BOOTSTRAP_SERVERS: ${{ secrets.TEST_KAFKA_BOOTSTRAP_SERVERS }} | ||
| PLAYWRIGHT_KAFKA_SCHEMA_REGISTRY_URL: ${{ secrets.TEST_KAFKA_SCHEMA_REGISTRY_URL }} | ||
| PLAYWRIGHT_GLUE_ACCESS_KEY: ${{ secrets.TEST_GLUE_ACCESS_KEY }} | ||
| PLAYWRIGHT_GLUE_SECRET_KEY: ${{ secrets.TEST_GLUE_SECRET_KEY }} | ||
| PLAYWRIGHT_GLUE_AWS_REGION: ${{ secrets.TEST_GLUE_AWS_REGION }} | ||
| PLAYWRIGHT_GLUE_ENDPOINT: ${{ secrets.TEST_GLUE_ENDPOINT }} | ||
| PLAYWRIGHT_GLUE_STORAGE_SERVICE: ${{ secrets.TEST_GLUE_STORAGE_SERVICE }} | ||
| PLAYWRIGHT_MYSQL_USERNAME: ${{ secrets.TEST_MYSQL_USERNAME }} | ||
| PLAYWRIGHT_MYSQL_PASSWORD: ${{ secrets.TEST_MYSQL_PASSWORD }} | ||
| PLAYWRIGHT_MYSQL_HOST_PORT: ${{ secrets.TEST_MYSQL_HOST_PORT }} | ||
| PLAYWRIGHT_MYSQL_DATABASE_SCHEMA: ${{ secrets.TEST_MYSQL_DATABASE_SCHEMA }} | ||
| PLAYWRIGHT_POSTGRES_USERNAME: ${{ secrets.TEST_POSTGRES_USERNAME }} | ||
| PLAYWRIGHT_POSTGRES_PASSWORD: ${{ secrets.TEST_POSTGRES_PASSWORD }} | ||
| PLAYWRIGHT_POSTGRES_HOST_PORT: ${{ secrets.TEST_POSTGRES_HOST_PORT }} | ||
| PLAYWRIGHT_POSTGRES_DATABASE: ${{ secrets.TEST_POSTGRES_DATABASE }} | ||
| PLAYWRIGHT_AIRFLOW_HOST_PORT: ${{ secrets.TEST_AIRFLOW_HOST_PORT }} | ||
| PLAYWRIGHT_ML_MODEL_TRACKING_URI: ${{ secrets.TEST_ML_MODEL_TRACKING_URI }} | ||
| PLAYWRIGHT_ML_MODEL_REGISTRY_URI: ${{ secrets.TEST_ML_MODEL_REGISTRY_URI }} | ||
| PLAYWRIGHT_S3_STORAGE_ACCESS_KEY_ID: ${{ secrets.TEST_S3_STORAGE_ACCESS_KEY_ID }} | ||
| PLAYWRIGHT_S3_STORAGE_SECRET_ACCESS_KEY: ${{ secrets.TEST_S3_STORAGE_SECRET_ACCESS_KEY }} | ||
| PLAYWRIGHT_S3_STORAGE_END_POINT_URL: ${{ secrets.TEST_S3_STORAGE_END_POINT_URL }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: playwright-knowledge-graph-report | ||
| path: openmetadata-ui/src/main/resources/ui/playwright/output/playwright-report | ||
| retention-days: 5 | ||
|
|
||
| - name: Clean Up | ||
| if: always() | ||
| run: | | ||
| docker compose -f docker/development/docker-compose-postgres.yml -f docker/development/docker-compose-fuseki.yml down --remove-orphans || true | ||
| docker compose -f docker/development/docker-compose-postgres.yml down --remove-orphans || true | ||
| sudo rm -rf ${PWD}/docker/development/docker-volume | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.