Skip to content

docs: mark Logging as complete, Domains as in-progress in feature table#236

Open
typotter wants to merge 1 commit intomainfrom
typo/readme-feature-status-update
Open

docs: mark Logging as complete, Domains as in-progress in feature table#236
typotter wants to merge 1 commit intomainfrom
typo/readme-feature-status-update

Conversation

@typotter
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Verify LoggerFactory.getLogger and LoggingHook constructor signatures match the example
  • Confirm the domains spec link resolves correctly

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to reflect the current implementation status of Logging and Domains features. It introduces documentation for the LoggingHook and Logger interface, including a code example, and provides a link to the OpenFeature documentation for Domains. Feedback was provided to improve the technical accuracy of the LoggingHook description regarding its default logger behavior.

Comment thread README.md Outdated
Full logging stack (#233, #221, #220) is now merged — update Logging
from ⚠️ to ✅. Domain binding (#231) is actively in development —
update Domains from ❌ to ⚠️ and rewrite the section to reflect
current state with a link to the OpenFeature Domains docs.

Signed-off-by: Tyler Potter <tyler.john.potter@gmail.com>
@typotter typotter changed the title docs: mark Logging and Domains as in-progress in feature table docs: mark Logging as complete, Domains as in-progress in feature table Apr 21, 2026
@typotter typotter force-pushed the typo/readme-feature-status-update branch from 8f72edb to 9e2ceaf Compare April 21, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants