docs: mark Logging as complete, Domains as in-progress in feature table#236
Open
docs: mark Logging as complete, Domains as in-progress in feature table#236
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to reflect the current implementation status of Logging and Domains features. It introduces documentation for the LoggingHook and Logger interface, including a code example, and provides a link to the OpenFeature documentation for Domains. Feedback was provided to improve the technical accuracy of the LoggingHook description regarding its default logger behavior.
Full logging stack (#233, #221, #220) is now merged — update Logging from⚠️ to ✅. Domain binding (#231) is actively in development — update Domains from ❌ to⚠️ and rewrite the section to reflect current state with a link to the OpenFeature Domains docs. Signed-off-by: Tyler Potter <tyler.john.potter@gmail.com>
8f72edb to
9e2ceaf
Compare
beeme1mr
approved these changes
Apr 22, 2026
nicklasl
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoggingHookand theLoggerinterface are merged, but PII filtering (feat: Add PII filtering controls to LoggingHook #221) and full logging docs (docs: Add comprehensive logging documentation #220) are still openTest plan
LoggerFactory.getLoggerandLoggingHookconstructor signatures match the example