Conversation
There was a problem hiding this comment.
Code Review
This pull request updates @openfeature/react-sdk to version 1.4.0, introduces a new feature to expose JS SDK identity on client metadata, and bumps development dependencies for the core and web SDKs. The review feedback identifies a version mismatch in the release manifest, an outdated peer dependency for the web SDK that should match the new development version, and an inconsistency between the package's bundling strategy and the peer dependency instructions in the documentation.
| { | ||
| "packages/nest": "0.2.6", | ||
| "packages/react": "1.3.0", | ||
| "packages/react": "1.4.0", |
There was a problem hiding this comment.
There is a version mismatch between this manifest and the package.json of the react package. The manifest lists packages/web as 1.8.0 and packages/shared as 1.10.0, but packages/react/package.json (lines 54-55) has been updated to depend on @openfeature/web-sdk 1.9.0 and @openfeature/core 1.11.0. This inconsistency will likely cause issues during the release process or for consumers of the package.
| "@openfeature/core": "*", | ||
| "@openfeature/web-sdk": "*" | ||
| "@openfeature/core": "1.11.0", | ||
| "@openfeature/web-sdk": "1.9.0" |
There was a problem hiding this comment.
The devDependencies for @openfeature/web-sdk has been bumped to 1.9.0, likely to support the new identity features. However, the peerDependencies (line 50) still specifies ^1.8.0. To ensure that consumers have the necessary version of the web SDK for these new features, the peerDependencies should also be updated to ^1.9.0.
| "devDependencies": { | ||
| "@openfeature/core": "*", | ||
| "@openfeature/web-sdk": "*" | ||
| "@openfeature/core": "1.11.0", |
There was a problem hiding this comment.
@openfeature/core is being bumped to 1.11.0. Note that this package is currently bundled into the SDK (as it is not marked as external in the build scripts), yet the README (line 84) suggests users install it as a peer dependency. This inconsistency should be addressed to avoid confusion and potential duplicate dependency issues for users.
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
c3d9437 to
5e647c3
Compare
🤖 I have created a release beep boop
1.4.0 (2026-04-22)
✨ New Features
🧹 Chore
Dependencies
This PR was generated with Release Please. See documentation.