core: add Ethereum-compatible BLS12-381 serializators and operations to CryptoLib by Turalchik · Pull Request #4050 · nspcc-dev/neo-go

Turalchik · 2025-10-27T09:56:52Z

codecov · 2025-10-27T10:08:02Z

Codecov Report

❌ Patch coverage is 90.22005% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.49%. Comparing base (86a7038) to head (09d273a).
⚠️ Report is 78 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/core/native/crypto.go	91.84%	25 Missing and 2 partials ⚠️
pkg/core/native/crypto_blspoints.go	83.33%	9 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4050      +/-   ##
==========================================
+ Coverage   83.45%   83.49%   +0.04%     
==========================================
  Files         352      352              
  Lines       42754    43158     +404     
==========================================
+ Hits        35679    36036     +357     
- Misses       5323     5366      +43     
- Partials     1752     1756       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roman-khimov · 2025-10-28T05:36:25Z

It's not about aliases now, it's just a new function.

AnnaShaleva

Workflows are failing.

Also, need some time to check the main math logic.

AnnaShaleva · 2025-10-28T17:04:34Z

 	google.golang.org/protobuf v1.36.9 // indirect
 )
+
+replace github.com/nspcc-dev/neo-go/pkg/interop => ./pkg/interop


Remove it once PR is finilized.

AnnaShaleva · 2025-12-17T15:30:30Z


+func (p *blsPoint) FromBytesEth(buf []byte) error {
+	switch l := len(buf); l {
+	case bls12G1EncodedLength:


Add default case, return an appropriate error.

AnnaShaleva · 2025-12-17T15:30:49Z

 	}
 }

+func (p blsPoint) BytesEth() []byte {


Exported method needs a comment.

Ditto everywhere.

Close #4041. Signed-off-by: Tural Devrishev <tural@nspcc.ru>

AnnaShaleva · 2025-12-22T13:40:09Z

@txhsl could you please review the implementation one more time? This CryptoLib API is the final suggestion from our side. Our primary concern was neo-project/neo#4186 (comment), so we believe it's solved in this PR.

txhsl

Our primary concern was neo-project/neo#4186 (comment), so we believe it's solved in this PR.

Yes, I see the difference you've made, and the implementation is quite clear to me.

Maybe it's time for @Jim8y to have a look on this, he's a bit confused about the idea at the beginning.

txhsl · 2025-12-23T03:11:55Z

+		res = append(res, p.BytesEth()...)
+		scalarBE := scalar.Bytes()
+		scalarBytes := make([]byte, bls12ScalarLength)
+		copy(scalarBytes[bls12ScalarLength-len(scalarBE):], scalarBE)


Maybe a length/border check first?

It will panic with slice bounds out of range if scalarBE doesn't fit into bls12ScalarLength.

It will panic with slice bounds out of range if scalarBE doesn't fit into bls12ScalarLength.

Oh, yes.

txhsl · 2025-12-23T03:48:07Z

+const (
+	g1Hex                            = "97f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb"
+	g2Hex                            = "93e02b6052719f607dacd3a088274f65596bd0d09920b61ab5da61bbdc7f5049334cf11213945d57e5ac7d055d042b7e024aa2b2f08f0a91260805272dc51051c6e47ad4fa403b02b4510b647ae3d1770bac0326a805bbefd48056c8c121bdb8"
+	ethG1MultiExpSingleInputHex      = "0000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000008b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e10000000000000000000000000000000000000000000000000000000000000011"


Maybe you can have more EVM test cases for operations other than MultiExp, although IMO they have already provided enough guarantees.

Agree, at least we need to add:

Compatibility tests for bls12381PairingList with some hex-encoded raw data that may be ported to C#.

Bi-directional serializators tests for all added APIs: ensure that result of serialize(deserialize(input)) matches the input exactly.

AnnaShaleva · 2025-12-23T09:22:54Z

+	return stackitem.NewByteArray(res)
+}
+
+func (c *Crypto) bls12381SerializeEthList(_ *interop.Context, args []stackitem.Item) stackitem.Item {


Every introduced method needs a comment explaining which type of conversion it's performing, like it's done for bls12381SerializeList.

AnnaShaleva · 2025-12-23T09:26:00Z

+		res = append(res, p.BytesEth()...)
+		scalarBE := scalar.Bytes()
+		scalarBytes := make([]byte, bls12ScalarLength)
+		copy(scalarBytes[bls12ScalarLength-len(scalarBE):], scalarBE)


It will panic with slice bounds out of range if scalarBE doesn't fit into bls12ScalarLength.

AnnaShaleva · 2025-12-23T09:30:20Z

+const (
+	g1Hex                            = "97f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb"
+	g2Hex                            = "93e02b6052719f607dacd3a088274f65596bd0d09920b61ab5da61bbdc7f5049334cf11213945d57e5ac7d055d042b7e024aa2b2f08f0a91260805272dc51051c6e47ad4fa403b02b4510b647ae3d1770bac0326a805bbefd48056c8c121bdb8"
+	ethG1MultiExpSingleInputHex      = "0000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000008b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e10000000000000000000000000000000000000000000000000000000000000011"


Agree, at least we need to add:

Compatibility tests for bls12381PairingList with some hex-encoded raw data that may be ported to C#.

Bi-directional serializators tests for all added APIs: ensure that result of serialize(deserialize(input)) matches the input exactly.

Turalchik requested review from AnnaShaleva and roman-khimov as code owners October 27, 2025 09:56

Turalchik force-pushed the bls12-eth-aliases branch from 5d040cd to 11020de Compare October 27, 2025 10:01

AnnaShaleva reviewed Oct 28, 2025

View reviewed changes

AnnaShaleva reviewed Nov 4, 2025

View reviewed changes

Comment thread pkg/core/native/native_test/cryptolib_test.go Outdated

Comment thread pkg/core/native/native_test/management_test.go Outdated

Comment thread pkg/core/native/crypto.go Outdated

AnnaShaleva added the blocked Can't be done because of something label Nov 6, 2025

Turalchik force-pushed the bls12-eth-aliases branch from 11020de to 5a566d4 Compare November 19, 2025 10:45

Turalchik force-pushed the bls12-eth-aliases branch 6 times, most recently from 0d9946b to 531864f Compare December 8, 2025 20:06

AnnaShaleva reviewed Dec 9, 2025

View reviewed changes

Turalchik force-pushed the bls12-eth-aliases branch 10 times, most recently from 008e092 to db38756 Compare December 11, 2025 13:56

AnnaShaleva removed the blocked Can't be done because of something label Dec 11, 2025

Turalchik force-pushed the bls12-eth-aliases branch 3 times, most recently from 3aabc28 to 40f06e3 Compare December 12, 2025 08:14

Turalchik force-pushed the bls12-eth-aliases branch 5 times, most recently from 14c0d14 to 22bdc25 Compare December 12, 2025 18:00

Turalchik commented Dec 12, 2025

View reviewed changes

Comment thread pkg/core/native/crypto.go Outdated

Turalchik force-pushed the bls12-eth-aliases branch 2 times, most recently from 444f75c to 84e7b36 Compare December 15, 2025 10:13

AnnaShaleva reviewed Dec 15, 2025

View reviewed changes

Comment thread pkg/core/native/crypto.go Outdated

Turalchik force-pushed the bls12-eth-aliases branch from 84e7b36 to c0711db Compare December 15, 2025 12:17

AnnaShaleva reviewed Dec 15, 2025

View reviewed changes

AnnaShaleva changed the title ~~core: add Ethereum-compatible aliases for BLS12-381~~ core: add Ethereum-compatible serializators and operations for BLS12-381 to CryptoLib Dec 15, 2025

AnnaShaleva changed the title ~~core: add Ethereum-compatible serializators and operations for BLS12-381 to CryptoLib~~ core: add Ethereum-compatible BLS12-381 serializators and operations to CryptoLib Dec 15, 2025

Turalchik force-pushed the bls12-eth-aliases branch 4 times, most recently from e438231 to f99c5a9 Compare December 17, 2025 15:08

AnnaShaleva mentioned this pull request Dec 17, 2025

Add Ethereum-compatible aliases for BLS12-381 neo-project/neo#4186

Closed

10 tasks

AnnaShaleva reviewed Dec 17, 2025

View reviewed changes

Turalchik force-pushed the bls12-eth-aliases branch from f99c5a9 to 88984f8 Compare December 17, 2025 18:32

core: add Ethereum-compatible aliases for BLS12-381

09d273a

Close #4041. Signed-off-by: Tural Devrishev <tural@nspcc.ru>

Turalchik force-pushed the bls12-eth-aliases branch from 88984f8 to 09d273a Compare December 17, 2025 18:34

Turalchik requested a review from AnnaShaleva December 17, 2025 19:03

AnnaShaleva requested a review from txhsl December 22, 2025 13:35

txhsl reviewed Dec 23, 2025

View reviewed changes

AnnaShaleva reviewed Dec 23, 2025

View reviewed changes

Jim8y mentioned this pull request Dec 23, 2025

Add BLS12-381 Ethereum compatibility helpers and parity tests neo-project/neo#4394

Open

AnnaShaleva added the blocked Can't be done because of something label Jan 23, 2026

Conversation

Turalchik commented Oct 27, 2025

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

roman-khimov commented Oct 28, 2025

Uh oh!

AnnaShaleva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AnnaShaleva Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnnaShaleva commented Dec 22, 2025

Uh oh!

txhsl left a comment

Choose a reason for hiding this comment

Uh oh!

txhsl Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 27, 2025 •

edited

Loading

AnnaShaleva Oct 28, 2025 •

edited

Loading

txhsl Dec 23, 2025 •

edited

Loading