use originalUrl to detect request for a wasm file#36
Open
Mati20041 wants to merge 1 commit intonshen:mainfrom
Open
use originalUrl to detect request for a wasm file#36Mati20041 wants to merge 1 commit intonshen:mainfrom
Mati20041 wants to merge 1 commit intonshen:mainfrom
Conversation
Owner
|
hi @Mati20041 thanks for you PR, please check |
Author
|
@nshen Hi! thanks for the proposition, but I'm not quite sure if I'll stick to the rust ecosystem for a longer time. I'm still exploring it :) |
|
Looks good to me, fixed my issue 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the newest vite (tested on 5.3.4) the
req.urlis changed byhtmlFallbackMiddlewareto/index.htmlif there is no available resource (ie. in/publicdirectory) under the requested url. It stores the original browser's path inreq.originalUrl.I fixed it because I'm starting to learn about using Rust in the webassembly and I like this plugin :)