Fix bundler looking for index.<chunk_hash>.wasm#16
Open
greym0uth wants to merge 1 commit intonshen:mainfrom
Open
Fix bundler looking for index.<chunk_hash>.wasm#16greym0uth wants to merge 1 commit intonshen:mainfrom
greym0uth wants to merge 1 commit intonshen:mainfrom
Conversation
Owner
|
hi @greym0uth thanks for you PR, please check #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like I missed something in my initial PR as that made it work for
vitebut didn't work withvite buildandvite preview.It seems newer versions of wasm-pack or at least my version uses
import.meta.urlfor getting the current file, so the existing regex replace isn't capturing it so I get a 404 fetching the wasm as its looking forindex.<chunk_hash>_bg.wasmwhich doesnt exist.This also uses the
transformhook to replace theinputin themodulePathsentry file's because I was running into an issue with pnpm caching; I just removed theisNodeModulelogic from thebuildStartas thetransformhandles that piece now. I left thecratePathsvariant in thebuildStartas it relies on thefs.copyso I didn't want to break anything in that aspect.