Add 'Personal Links' column with any social media links if added#4
Open
siddheshranade wants to merge 2 commits intonqureshi:mainfrom
Open
Add 'Personal Links' column with any social media links if added#4siddheshranade wants to merge 2 commits intonqureshi:mainfrom
siddheshranade wants to merge 2 commits intonqureshi:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
I'm not able to see why the deployment failed, let me know if there's anything I need to fix here. |
Author
|
Bump @nqureshi |
Owner
|
Thanks @siddheshranade! Requesting a fix: the current logic seems to parse everything into a URL, even when it's not. So in a case like below, you get 8 URLs, some of which are broken URLS (e.g. "https://austin" in the below example.) 
Once fixed I'll merge. |
Author
|
@nqureshi Back to you |
Author
|
@nqureshi Bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nqureshi
I wanted to contact someone from EV Winners list but couldn't find their social media, because of which I then tinkered around in the repo to see if this data was present and if I could add it to the website, which I was able to.
This PR adds a new
Personal Linkscolumn and if the winner had entered any links, adds them to the table like so: