permission: add --allow-env flag for environment variable access control#62827
Open
nabeel378 wants to merge 5 commits intonodejs:mainfrom
Open
permission: add --allow-env flag for environment variable access control#62827nabeel378 wants to merge 5 commits intonodejs:mainfrom
nabeel378 wants to merge 5 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Signed-off-by: nabeel378 <mohammadnabeeljameel@gmail.com>
Signed-off-by: nabeel378 <mohammadnabeeljameel@gmail.com>
nabeel378
force-pushed
the
feat/permission-allow-env-flag
branch
from
9c74582 to
f3544f8
Compare
Signed-off-by: nabeel378 <mohammadnabeeljameel@gmail.com>
…r environment variables Signed-off-by: nabeel378 <mohammadnabeeljameel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--allow-envpermission flag to control access to environmentvariables when the permission model is enabled (
--permission).Supported usage:
--allow-env— grants access to all environment variables--allow-env=HOME,PATH— grants access only to specified variablesWhen
--permissionis enabled without--allow-env, all calls toprocess.envwill throwERR_ACCESS_DENIED.Fixes: #62424