Skip to content

doc,test: mem protection must be observed in ffi#62818

Open
bengl wants to merge 1 commit intonodejs:mainfrom
bengl:bengl/ffi-mem-prot-doc-test
Open

doc,test: mem protection must be observed in ffi#62818
bengl wants to merge 1 commit intonodejs:mainfrom
bengl:bengl/ffi-mem-prot-doc-test

Conversation

@bengl
Copy link
Copy Markdown
Member

@bengl bengl commented Apr 19, 2026

When using ffi.toBuffer, memory protection on any memory pages exposed must be observed by the caller, otherwise crashes will occur.

Now documented, and tested.

When using ffi.toBuffer, memory protection on any memory pages exposed
must be observed by the caller, otherwise crashes will occur.

Now documented, and tested.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 19, 2026
@bengl bengl requested a review from ShogunPanda April 19, 2026 14:05
@bengl bengl marked this pull request as ready for review April 19, 2026 14:06
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.54%. Comparing base (3f52482) to head (43f68d7).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62818      +/-   ##
==========================================
- Coverage   91.55%   89.54%   -2.02%     
==========================================
  Files         356      706     +350     
  Lines      149601   218222   +68621     
  Branches    23395    41686   +18291     
==========================================
+ Hits       136967   195398   +58431     
- Misses      12371    14739    +2368     
- Partials      263     8085    +7822     

see 505 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants