test: export isRiscv64 from common module#62609
Open
JamieMagee wants to merge 1 commit intonodejs:mainfrom
Open
test: export isRiscv64 from common module#62609JamieMagee wants to merge 1 commit intonodejs:mainfrom
JamieMagee wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
cjihrig
reviewed
Apr 5, 2026
10 tasks
JamieMagee
force-pushed
the
test-export-isriscv64
branch
from
772a762 to
a87ddf7
Compare
cjihrig
approved these changes
Apr 6, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62609 +/- ##
=======================================
Coverage 89.62% 89.63%
=======================================
Files 706 706
Lines 219137 219137
Branches 41981 41980 -1
=======================================
+ Hits 196404 196413 +9
- Misses 14614 14627 +13
+ Partials 8119 8097 -22 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Apr 6, 2026
Collaborator
richardlau
previously approved these changes
Apr 7, 2026
JamieMagee
force-pushed
the
test-export-isriscv64
branch
from
a87ddf7 to
fdb883e
Compare
Contributor
Author
|
@richardlau I rebased on top of latest |
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
Author
|
Is this possible to be merged? |
isRiscv64 is defined and used internally for the timeout multiplier but was not exported. Export it alongside the other platform booleans (isLinux, isFreeBSD, isPi, etc.) so tests can use common.isRiscv64 instead of inlining process.arch checks. Refs: nodejs/build#4099 Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
JamieMagee
force-pushed
the
test-export-isriscv64
branch
from
fdb883e to
ebf12a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isRiscv64was defined and used internally for the timeout multiplier, but wasn't exported. Tests that needed to check for riscv64 had to inlineprocess.arch === 'riscv64'instead.Add it to the exports alongside the other platform booleans.