Skip to content

Remove assert() on CallLike::getArgs(), returns empty array on first class callable #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samsonasik wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Remove assert() on CallLike::getArgs(), returns empty array on first class callable #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/PhpParser/Node/Expr/CallLike.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ public function isFirstClassCallable(): bool {
}

/**
* Assert that this is not a first-class callable and return only ordinary Args.
* Return only ordinary Args.
*
* @return Arg[]
*/
public function getArgs(): array {
assert(!$this->isFirstClassCallable());
if ($this->isFirstClassCallable()) {
return [];
}
return $this->getRawArgs();
}

Expand Down