fix(tts): sync canonical/alias fields to prevent voice/model/base URL rollback#968
Open
dbmizrahi wants to merge 4 commits intonextlevelbuilder:devfrom
Open
fix(tts): sync canonical/alias fields to prevent voice/model/base URL rollback#968dbmizrahi wants to merge 4 commits intonextlevelbuilder:devfrom
dbmizrahi wants to merge 4 commits intonextlevelbuilder:devfrom
Conversation
aaa892a to
f4ec1c4
Compare
Contributor
Author
|
Since I don't have permissions to re-run the PR checks I can only confirm that integration test that failed in the pipeline has passed on my machine: |
… method sessions.compact as a write method
…n name was fixed by renaming the function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a TTS settings persistence bug where updated provider values (voice/model/base URL) could revert after page reload. The fix keeps canonical and compatibility alias fields synchronized in the UI payload so backend resolution cannot persist stale values.
Type
main)Target Branch
devChecklist
go build ./...passesgo build -tags sqliteonly ./...passes (if Go changes)go vet ./...passesgo test -race ./...cd ui/web && pnpm build(if UI changes)$1, $2(no string concat)internal/upgrade/version.go(if new migration)Test Plan
elevenlabsand change:minimaxfor voice/model.Validation performed in this fix:
ui/web/src/pages/tts/tts-page.tsxlint: no errors/warnings.ui/web/src/pages/tts/sections/credentials-section.tsxlint: no errors/warnings.Implementation notes covered by this PR:
voiceandvoice_idare updated together forelevenlabsandminimax.modelandmodel_idare updated together forelevenlabsandminimax.api_baseandbase_urlare updated together forelevenlabs.