Release 8.2: Fix alias lookup bug by replacing InterViews String with std::string.#3687
Open
nrnhines wants to merge 2 commits intorelease/8.2from
Open
Release 8.2: Fix alias lookup bug by replacing InterViews String with std::string.#3687nrnhines wants to merge 2 commits intorelease/8.2from
nrnhines wants to merge 2 commits intorelease/8.2from
Conversation
|
nrnhines
changed the title
alkino
reviewed
Feb 18, 2026
Comment on lines
-373
to
375
| String s(name); | ||
| std::string s(name); | ||
| const auto& it = symtab_.find(s); |
Member
There was a problem hiding this comment.
We can avoid copy by using std::string_view here.
const auto& it = symtab_.find(std::string_view(name));
This is true for all the subsequent ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the key to an std::map is an InterViews String, the lookup could match to a non-identical String.
This is fixed by using an std::map with an std::string key
Closes #3688