Skip to content

Migrate dev and docs from optional dependencies to PEP 735 dependency groups#956

Open
lochhh wants to merge 4 commits intomainfrom
dep-groups
Open

Migrate dev and docs from optional dependencies to PEP 735 dependency groups#956
lochhh wants to merge 4 commits intomainfrom
dep-groups

Conversation

@lochhh
Copy link
Copy Markdown
Member

@lochhh lochhh commented Apr 10, 2026

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Closes #955

What does this PR do?

References

The NIU build docs action needs to be updated as well (neuroinformatics-unit/actions#158) as it currently uses the old [docs] syntax to install docs dependencies.

How has this PR been tested?

  • build docs@main fails
  • build docs@build-docs-group-dep passes

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4309245) to head (65a124c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #956   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         2691      2691           
=========================================
  Hits          2691      2691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@lochhh lochhh marked this pull request as ready for review April 13, 2026 16:49
@lochhh lochhh requested a review from niksirbi April 13, 2026 16:56
Copy link
Copy Markdown
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lochhh! This was overdue.

At first I was wondering why the test action didn't break, but then I realised because the env for that is installed by tox which is configured in pyproject.toml, so all good.

Should we open the same PR in the python-cookiecutter and at least in our other behavioural repos? (so we don't run the risk of confusing the dev installation syntax across projects).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate dev and docs from optional dependencies to PEP 735 dependency groups

2 participants