Skip to content

Analyze task-like method signatures#1588

Draft
Jim8y wants to merge 1 commit intomaster-n3from
fix/analyze-task-like-signatures
Draft

Analyze task-like method signatures#1588
Jim8y wants to merge 1 commit intomaster-n3from
fix/analyze-task-like-signatures

Conversation

@Jim8y
Copy link
Copy Markdown
Contributor

@Jim8y Jim8y commented Apr 18, 2026

Summary

  • add an analyzer rule for task-like method return and parameter types
  • report Task, Task, ValueTask, and ValueTask in non-async contract signatures
  • register the new analyzer rule and cover it with unit tests

Validation

  • dotnet test tests/Neo.SmartContract.Analyzer.UnitTests/Neo.SmartContract.Analyzer.UnitTests.csproj --filter "TaskLikeMethodSignature_ShouldReportDiagnostic" --no-restore
  • dotnet test tests/Neo.SmartContract.Analyzer.UnitTests/Neo.SmartContract.Analyzer.UnitTests.csproj --no-restore

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.25%. Comparing base (512f278) to head (afe5579).

Additional details and impacted files
@@            Coverage Diff             @@
##           master-n3    #1588   +/-   ##
==========================================
  Coverage      80.25%   80.25%           
==========================================
  Files            295      295           
  Lines          25456    25456           
  Branches        3453     3453           
==========================================
  Hits           20429    20429           
  Misses          4132     4132           
  Partials         895      895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Wi1l-B0t
Wi1l-B0t previously approved these changes Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants