Fix system detection. Update liquidsoap patch.#28
Open
GroundTruthNZ wants to merge 1 commit intoned-kelly:masterfrom
Open
Fix system detection. Update liquidsoap patch.#28GroundTruthNZ wants to merge 1 commit intoned-kelly:masterfrom
GroundTruthNZ wants to merge 1 commit intoned-kelly:masterfrom
Conversation
pedkfuri
approved these changes
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there
I was so pleased to finally be able to get Libretime working in Docker. Thanks for all your good work on this. Some suggested tweaks here.
With the latest install script, the system detection doesn't work. Seeing we are in docker and specifying Xenial it is safe to lock that down I think.
Also the patch for Liquidsoap no longer applies. Using a later one here.
Regards
Daniel