Fix typo in McpPromptRegistry and improve JSON safety#349
Fix typo in McpPromptRegistry and improve JSON safety#349josesimoes merged 1 commit intonanoframework:mainfrom
Conversation
McpPromptRegistry.cs에서 promtps 오타를 prompts로 수정하였고, prompts 및 tools 목록을 JSON 문자열로 변환할 때 항목이 없을 경우 예외가 발생하지 않도록 Count > 0 조건문을 추가했습니다. 동일한 안전성 개선을 McpToolRegistry.cs에도 적용했습니다.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
josesimoes
left a comment
There was a problem hiding this comment.
Nice catch. The typo is on me... 😅
😅 |



Description
promtpstopromptsinMcpPromptRegistry.cs.Count > 0check to prevent exceptions when converting prompts and tools to JSON strings if no items exist. Applied the same safety improvements toMcpToolRegistry.cs.Motivation and Context
How Has This Been Tested?
nanoFramework.WebServer/tests/McpEndToEndTest/Program.csScreenshots
Types of changes
Checklist: