This repository was archived by the owner on Jan 26, 2022. It is now read-only.
[WIP] Tpt2.8: same commits as before but ontop of the newest master.#429
Open
schwancr wants to merge 12 commits intomsmbuilder:masterfrom
Open
[WIP] Tpt2.8: same commits as before but ontop of the newest master.#429schwancr wants to merge 12 commits intomsmbuilder:masterfrom
schwancr wants to merge 12 commits intomsmbuilder:masterfrom
Conversation
…rycecr used in msmexplorer as suggested in Frank Noe's paper on TPT. Additionally I re-wrote the dijkstra code so that it's a bit more readable and added a lot of comments. Conflicts: scripts/FindPaths.py I'll have to re-edit this script.
Conflicts: MSMBuilder/tpt.py
… FindPaths test since it was written for the old code. I don't think it's necessary to have a test other than knowing if it actually runs since it just has two lines: tpt.calculate_net_fluxes and tpt.get_paths Conflicts: tests/test_tpt.py
… since the other test is an example where I know the answer. It would be nice, however to have a transition matrix with a known flux. This also shouldn't be difficult to generate, just have to think it up.
schwancr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see PR #257