Draft
Conversation
3a71ddf to
c90f43d
Compare
c90f43d to
c662bd1
Compare
Contributor
Author
|
Looks like this property API is not available in I guess we're good to wait for next Ubuntu LTS next year: |
Contributor
Author
|
I just tried this branch in my project, and it crashes. Marking as draft, I guess it's not quite ready yet anyway 😅 |
Contributor
Author
|
Ok. That one is fixed with 13d5981 I'll start using this branch in my project. I leave it as a draft for now, as there is still the issue with Ubuntu anyway. Once I find it stable enough for my project, I'll remove the draft flag. |
Owner
|
Hey, thanks for this PR! Let me know when you deem it ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds part of the property API of taglib.
The properties are basically a key/value map. The keys are strings and the values are list of strings. To keep up with the original design, one must create a getter for a specific property.
All the functions of the property API have been ported, but this one, as I don't need it:
But I can add it as part of this PR if you think that'd be needed to merge it.
For the context, I'm building a CLI tagger based on
htaglib: htagcli. I need to access thealbumartisttag, which is not exposed in the simple API. It is really a shame, as it is an important tag for organizing audio files.