Conversation
There was a problem hiding this comment.
Pull request overview
Updates the extension’s course/subject dataset (per Issue #48) and includes an incidental dependency lockfile change.
Changes:
- Added a large set of new subjects to
assets/data/subject.json. - Updated
pnpm-lock.yamlwith a transitive dependency version change (undici).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile updated; transitive undici version changed. |
| assets/data/subject.json | Expanded the subject catalog with many additional course entries. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "code": "POLI11304", | ||
| "name": "Triết học Mác - Lênin", | ||
| "credit": "3" | ||
| }, | ||
| { | ||
| "code": "VIET1306", | ||
| "name": "Cơ sở ngôn ngữ học", | ||
| "credit": "3" |
There was a problem hiding this comment.
POLI11304 looks like a typo/inconsistent code for “Triết học Mác - Lênin”. The file already contains POLI1304 for the same subject, so this new entry will create a confusing duplicate in the subject picker; please correct the code (or remove this entry if it’s not a distinct course).
| "code": "POLI11304", | |
| "name": "Triết học Mác - Lênin", | |
| "credit": "3" | |
| }, | |
| { | |
| "code": "VIET1306", | |
| "name": "Cơ sở ngôn ngữ học", | |
| "credit": "3" | |
| "code": "VIET1306", | |
| "name": "Cơ sở ngôn ngữ học", | |
| "credit": "3" |
| "credit": "3" | ||
| }, | ||
| { | ||
| "code": "ACC2301", |
There was a problem hiding this comment.
The new subject code ACC2301 is inconsistent with the code format used elsewhere in this file (e.g., ACCO2301, ACCO1325). If this is meant to be Accounting (ACCO...), it’s likely a typo and will create a near-duplicate “Nguyên lý kế toán” entry in the picker; please verify and align the code with the correct one.
| "code": "ACC2301", | |
| "code": "ACCO2301", |
detail at #48