Conversation
| } | ||
| if resp.Status == ocsp.Revoked { | ||
| status.RevokedAt = resp.RevokedAt | ||
| } |
There was a problem hiding this comment.
The revoked_at field is still stored here, but it looks to be detected by .IsZero(), which doesn't really make sense as a revocation time anyway.
The status field is always checked in the printer anyway.
tls_observatory=# select * from analysis where worker_name='ocspStatus' and scan_id=5;
id | scan_id | worker_name | success | output
----+---------+-------------+---------+-----------------------------------------------------
25 | 5 | ocspStatus | t | {"status": 0, "revoked_at": "0001-01-01T00:00:00Z"}
|
It looks like there's some (stalled) work on a badssl.com example for revoked/expired OCSP. I don't see an example on their main site. |
|
@adamdecaf Thanks for finishing this! I was trying to find time to complete this, but I've been really busy lately. |
jvehent
left a comment
There was a problem hiding this comment.
Works locally and code looks good, just one nit on the printer output.
| results = append(results, fmt.Sprintf(" - Revoked at %s\n", result.RevokedAt.Format(time.RFC3339))) | ||
| default: | ||
| results = append(results, fmt.Sprintf(" - Unknown status code %d\n", result.Status)) | ||
| } |
There was a problem hiding this comment.
Lets put everything on a single line like we did for the CAA and CRL workers. The output should be fmt.Sprintf("* OCSP: <status>"). Also, don't include a newline, the printer does that automatically.
This builds on #286 and takes the work done there to finish the worker.
Issue: #199