Fix JetStream3 y-axis label showing instead of for some subtests#585
Open
92kns wants to merge 1 commit intomozilla-frontend-infra:masterfrom
Open
Fix JetStream3 y-axis label showing instead of for some subtests#58592kns wants to merge 1 commit intomozilla-frontend-infra:masterfrom
92kns wants to merge 1 commit intomozilla-frontend-infra:masterfrom
Conversation
✅ Deploy Preview for firefox-performance-dashboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 63.46% 63.46%
=======================================
Files 12 12
Lines 323 323
Branches 48 49 +1
=======================================
Hits 205 205
Misses 103 103
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
92kns
force-pushed
the
fix/jetstream3-yaxis-label
branch
from
d725616 to
0dfdb2b
Compare
92kns
force-pushed
the
fix/jetstream3-yaxis-label
branch
from
28ff338 to
bb32f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #558
Perfherder's
lower_is_betterflag is inconsistent across platforms for the JetStream3 signature, and chartJsOptions was computed once from the first response and reused for all charts, so subtests would inherit the parent's label (or vice versa).by setting explicit yLabel: 'Score' on the JetStream3 benchmark configs, and generating chart options per-graph so subtests always derive their label from their own lower_is_better metadata.