Skip to content

Bug 1976263 - Cookie banner hides cookie page#2599

Merged
dklawren merged 7 commits intomozilla-bteam:masterfrom
kyoshino:1976263-cookie-banner-overlap
Apr 16, 2026
Merged

Bug 1976263 - Cookie banner hides cookie page#2599
dklawren merged 7 commits intomozilla-bteam:masterfrom
kyoshino:1976263-cookie-banner-overlap

Conversation

@kyoshino
Copy link
Copy Markdown
Collaborator

@kyoshino kyoshino commented Apr 15, 2026

Bug 1976263 - Cookie banner hides cookie page

  • Add a var to hide the banner only on the cookie settings page
  • Fix JS-embedded config
    • Param('cookie_consent_enabled') is a string, either '0' or '1', so cast it to boolean
    • Also cast Bugzilla.cgi.cookie_consent_required

kyoshino added a commit to kyoshino/bmo that referenced this pull request Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kohei!

@dklawren dklawren merged commit 926dfb6 into mozilla-bteam:master Apr 16, 2026
8 checks passed
@kyoshino kyoshino deleted the 1976263-cookie-banner-overlap branch April 16, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants