Skip to content

Bug 2031007 - When linking a Github pull request to a BMO bug, the attachment filename should contain the repository name in addition to the pull request ID#2595

Merged
dklawren merged 4 commits intomozilla-bteam:masterfrom
dklawren:2031007
Apr 15, 2026

Conversation

@dklawren
Copy link
Copy Markdown
Collaborator

No description provided.

…tachment filename should contain the repository name in addition to the pull request ID
Copilot AI review requested due to automatic review settings April 10, 2026 20:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates attachment filenames for linked GitHub pull requests so they include the repository name alongside the pull request number, improving clarity and reducing ambiguity across repos.

Changes:

  • Generate repo-aware filenames when attaching a GitHub PR URL via the web UI (new bug + new attachment).
  • Generate repo-aware filenames when attaching a GitHub PR via the REST webhook endpoint.
  • Update the “same PR on different bugs” fixup logic to use the new filename format.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
post_bug.cgi Detects GitHub PR URL pasted as attachment text and sets a repo+PR-based filename.
attachment.cgi Same as post_bug.cgi, but for adding attachments to existing bugs.
Bugzilla/API/V1/Github.pm Includes repo name in webhook-created attachment filenames and adjusts matching logic accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread post_bug.cgi Outdated
Comment thread attachment.cgi Outdated
Comment thread Bugzilla/API/V1/Github.pm
Comment thread Bugzilla/API/V1/Github.pm
@dklawren dklawren requested a review from cgsheeh April 10, 2026 20:54
Comment thread Bugzilla/API/V1/Github.pm Outdated
Comment thread post_bug.cgi Outdated
Comment thread post_bug.cgi Outdated
Comment thread post_bug.cgi Outdated
Comment thread attachment.cgi Outdated
Comment thread attachment.cgi Outdated
Comment thread attachment.cgi Outdated
Comment thread Bugzilla/API/V1/Github.pm
Comment thread Bugzilla/API/V1/Github.pm
@dklawren dklawren requested a review from suhaibmujahid April 13, 2026 14:47
Comment thread post_bug.cgi Outdated
@dklawren dklawren merged commit 1fd0740 into mozilla-bteam:master Apr 15, 2026
8 checks passed
@dklawren dklawren deleted the 2031007 branch April 15, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants