Skip to content

main.py and functions.py corrected#47

Open
IgorZakrocki wants to merge 1 commit intomkarwat:mainfrom
IgorZakrocki:good_practises
Open

main.py and functions.py corrected#47
IgorZakrocki wants to merge 1 commit intomkarwat:mainfrom
IgorZakrocki:good_practises

Conversation

@IgorZakrocki
Copy link
Copy Markdown

  1. Global variables in file87.py
  2. Import in weird places in file157.py
  3. Too long and unreadable variable names in the 157.py file, which describe too detailed the operation of the variables
  4. Unintuitive files name
  5. Variable name like "b = 0, c = 1" can only by if we provide a descriptions.
  6. Unnesserly fragment: yield 'finished'
  7. "init" in class PiContainer have to by declarate in this way:
    "def init(self, a = None):
    self.a = a if a is not None else []"
    , because we will by able to create new memory space for the new object.
  8. More description, the best to use English language
  9. When we imprt something the best way is to define what we use from the library
  10. Use 'pathlib' to manipulate paths, as this will reduce the chance of errors when opening our program in another OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant