Added max to bitmap and checkerboard textures, added tests for both m…#719
Open
Microno95 wants to merge 1 commit intomitsuba-renderer:masterfrom
Open
Added max to bitmap and checkerboard textures, added tests for both m…#719Microno95 wants to merge 1 commit intomitsuba-renderer:masterfrom
Microno95 wants to merge 1 commit intomitsuba-renderer:masterfrom
Conversation
njroussel
requested changes
May 8, 2023
Member
njroussel
left a comment
njroussel
left a comment
There was a problem hiding this comment.
I have a few comments (they are also true for the rebuild_internals method).
The suggestions might not actually be applicable/reasonable for your initial use case (volumes), I hadn't considered this when you opened the issue. I don't want to discourage using the Texture interface for volumes, but I don't think the Bitmap plugin is the appropriate choice.
Contributor
Author
|
Hey @njroussel, have you had a chance to read any of my comments? |
Microno95
force-pushed
the
feature/textures-max-implementation
branch
from
cf1d6b1 to
dfc9d21
Compare
Contributor
Author
|
I've updated the implementation to use the luminance rather than the component-wise maximum for both the RGB and Spectral cases. |
…ean and max calculations in vectorised variants
Microno95
force-pushed
the
feature/textures-max-implementation
branch
from
dfc9d21 to
046b414
Compare
wjakob
force-pushed
the
master
branch
3 times, most recently
from
3f3b8d0 to
1bdea6e
Compare
wjakob
force-pushed
the
master
branch
5 times, most recently
from
ff60350 to
4504654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds implementations of
maxfor the bitmap and checkerboard textures, adds python binding and mean/max tests for vectorised variants. Fixes #707Testing
Ran entire python test suite in
Releasemode.Checklist
cuda_*andllvm_*variants. If you can't test this, please leave below