fix: improve OS_ID parsing for quoted values in /etc/os-release#311212
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: improve OS_ID parsing for quoted values in /etc/os-release#311212Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When /etc/os-release contains ID="rocky" (with quotes), the old grep method fails to match and OS_ID becomes empty. This causes the check-requirements-linux.sh script to fail on Rocky Linux 8.5. The proposed fix sources /etc/os-release in a subshell, which properly handles both quoted and unquoted ID values without additional parsing. Fixes microsoft#232159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
This PR fixes #232159 - Devcontainer setup ad-hoc parsing fails on Rocky 8.5.
Problem
The script incorrectly parsed the field from when the value is quoted.
The previous regex approach:
Failed on Rocky Linux 8.5 which uses (quoted), returning an empty string.
Solution
Changed to:
This properly handles quoted values by loading the file as shell variables, which removes any surrounding quotes.
Verification
Tested locally with a mock containing :
Checklist
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.