fix: correct extension disable dropdown for workspace-only enabled state#311181
Open
tianhaocui wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: correct extension disable dropdown for workspace-only enabled state#311181tianhaocui wants to merge 1 commit intomicrosoft:mainfrom
tianhaocui wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ally When an extension is disabled globally but enabled for a workspace, DisableGloballyAction should not be enabled since the extension is already disabled at the global level. This prevents the dropdown from showing both 'Disable' and 'Disable (Workspace)' options. Fixes microsoft#244138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244138
Summary
When an extension is disabled globally but enabled for a workspace, the Disable button dropdown incorrectly shows both "Disable" and "Disable (Workspace)" items.
Root cause
DisableGloballyAction.update()checks for bothEnabledGloballyandEnabledWorkspaceenablement states. When an extension is disabled globally but enabled for workspace (EnabledWorkspace), bothDisableGloballyActionandDisableForWorkspaceActionbecome enabled, causing both to appear in the dropdown.Fix
Changed
DisableGloballyActionto only be enabled when the extension's enablement state isEnabledGlobally. When the extension is only enabled at the workspace level, the global disable action is no longer shown since the extension is already disabled globally.Test plan