Fix incorrect "Restart Extensions" for a disabled extension#311172
Open
argothiel wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix incorrect "Restart Extensions" for a disabled extension#311172argothiel wants to merge 1 commit intomicrosoft:mainfrom
argothiel wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When a marketplace extension is disabled and a dev extension with the same ID is running (via Extension Development Host), the disabled extension incorrectly shows a "Restart Extensions" badge. Clicking this badge removes the dev extension from EDH. Root cause: In extensionsWorkbenchService.ts, getRuntimeState() checks if a running extension with the same ID exists to determine if restart is needed. However, it doesn't distinguish between the marketplace extension and a dev extension - they're different extensions that happen to share an ID. Fix: Add a check for runningExtension.isUnderDevelopment in the isSameExtensionRunning condition for disabled extensions in getRuntimeState(). A dev extension should not trigger "Restart Extensions" for a disabled marketplace extension with the same ID. Fixes microsoft#311167
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a marketplace extension is disabled and a dev extension with the same ID is running (via Extension Development Host), the disabled extension incorrectly shows a "Restart Extensions" badge. Clicking this badge removes the dev extension from EDH.
Root cause: In extensionsWorkbenchService.ts, getRuntimeState() checks if a running extension with the same ID exists to determine if restart is needed. However, it doesn't distinguish between the marketplace extension and a dev extension - they're different extensions that happen to share an ID.
Fix: Add a check for runningExtension.isUnderDevelopment in the isSameExtensionRunning condition for disabled extensions in getRuntimeState(). A dev extension should not trigger "Restart Extensions" for a disabled marketplace extension with the same ID.
Fixes #311167