Fix wayland detection in snap electron-launch script#311038
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix wayland detection in snap electron-launch script#311038Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Check wayland_snappath ($XDG_RUNTIME_DIR/$wdisplay) instead of wayland_sockpath ($XDG_RUNTIME_DIR/../$wdisplay) for the wayland socket. The '..' in the path can cause the socket check to fail even when the socket exists at the actual path. Fixes microsoft#223591 Signed-off-by: RoomWithOutRoof <roomwithoutroof@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
This PR fixes issue #223591 where the wayland detection in the snap electron-launch script fails because the path check uses an incorrect path with
..resolution.The script checks
wayland_sockpath="$XDG_RUNTIME_DIR/../$wdisplay"but this resolves to/run/user/$uid/$wdisplaywhich may not be the correct socket path. The actual wayland socket path should be checked directly.This fix ensures that when running under Wayland, the correct socket path is detected, preventing the "Failed to open Wayland display, fallback to X11" warning.
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof