Open
Conversation
…CompileCommandsFile is false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug related to the handling of the
cmake.exportCompileCommandsFilesetting, ensuring that when it is set tofalse, the-DCMAKE_EXPORT_COMPILE_COMMANDSflag is omitted entirely rather than being passed asFALSE. This prevents CMake warnings for projects configured withLANGUAGES NONE. The changes also add targeted unit tests to validate the new logic. Resolves #4893 and tied to #4681Bug Fixes and Logic Improvements:
CMakeDriver(cmakeDriver.ts) so that the-DCMAKE_EXPORT_COMPILE_COMMANDSflag is only injected ifcmake.exportCompileCommandsFileistrueor unset, and omitted entirely iffalse, both for presets and kits modes. This resolves warnings in certain CMake projects. [1] [2]exportCompileCommands.test.ts) to verify the correct behavior for all combinations of the setting and argument overrides, ensuring the bug is fixed and future regressions are caught.