Enhance shlex parsing and add unit tests for POSIX and Windows#4898
Open
hanniavalera wants to merge 2 commits intomainfrom
Open
Enhance shlex parsing and add unit tests for POSIX and Windows#4898hanniavalera wants to merge 2 commits intomainfrom
hanniavalera wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses two main areas: it fixes the "Compile File" terminal closing too quickly (so users can see compilation output), and it significantly improves POSIX shell escape handling in the
shlexparser, especially for escaped quotes. It also expands and clarifies tests to ensure correct shell parsing across platforms. This PR addresses #4896Bug Fixes and User Experience Improvements
Shell Parsing and Escaping Improvements
shlex.splitis now fully compliant with shell rules: backslash escapes are handled correctly outside and inside quotes, and escaped quotes (e.g.,\") are interpreted as literal quotes when parsing compile commands. [1] [2] [3] [4] [5] [6]Testing Enhancements
Documentation
shlex.splitfunction, clarifying how escaping and quoting are handled in different modes.