Fix: Surface Ollama reasoning ("thinking") content in ChatMessageContent#13887
Closed
PrathamAditya wants to merge 12 commits intomicrosoft:mainfrom
Closed
Fix: Surface Ollama reasoning ("thinking") content in ChatMessageContent#13887PrathamAditya wants to merge 12 commits intomicrosoft:mainfrom
PrathamAditya wants to merge 12 commits intomicrosoft:mainfrom
Conversation
…tiguous tasktype additional property support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ollama responses can include a
thinking(reasoning) field, but this information is currently not exposed throughChatMessageContentin Semantic Kernel.This PR adds support to surface reasoning content by extracting it from the underlying
RawRepresentation.Changes
thinking) content is currently not propagated.thinkingfromRawRepresentationand include it inChatMessageContent.ItemsasTextContent.Behavior
Before:
content) is available.After:
thinking) is included alongside final response.Design Notes
RawRepresentationto avoid introducing a dependency on Ollama-specific types inSemanticKernel.Abstractions.Limitations / Future Work
This highlights a broader gap in the current abstraction:
Microsoft.Extensions.AImodel does not currently support reasoning/thinking as a first-class concept.Potential improvements:
ReasoningContenttypeHappy to align with maintainers on preferred direction.
Testing
GetChatMessageContent_ShouldIncludeThinking_WhenPresentInResponseAsync