fix(web-components): limit multi-select dropdown trigger width with overflow count#36015
Open
brianchristopherbrady wants to merge 1 commit intomasterfrom
Open
fix(web-components): limit multi-select dropdown trigger width with overflow count#36015brianchristopherbrady wants to merge 1 commit intomasterfrom
brianchristopherbrady wants to merge 1 commit intomasterfrom
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -159,6 +159,10 @@ export class BaseDropdown extends FASTElement { | |||
| return displayValue; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/MenuList 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39083 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.1st selected.chromium_2.png | 119 | Changed |
vr-tests-web-components/TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png | 288 | Changed |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In
fluent-dropdownwithmultipleselection enabled, the trigger button displays all selected option labels joined together (e.g."Apple, Banana, Cherry"). As more options are selected, this string grows unbounded, causing the trigger to expand in width and break fixed-width layouts.New Behavior
When two or more options are selected in
multiplemode, the trigger now displays the first selected option's text followed by an overflow count:"Apple +2". This keeps the trigger visually stable regardless of how many options are selected.Single-select and combobox behavior are unchanged.
Related Issue(s)
Screenshots
(before):
(after):
